-
Notifications
You must be signed in to change notification settings - Fork 47
BREAKING CHANGE: Replacing GitVersion 5 with 6 #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gaelcolas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to make it a breaking change?
If the template is not the same that's fine, but I feel existing repos can continue to work with gitversion v5.
There's another couple of points I'd like to discuss to clarify, but generally I think the way it works is ok.
Let's discuss...
Right, in this way it is not a breaking change. GitVersion 6 will only be used by projects created after the change. |
|
@gaelcolas, I have done the changes that we have discussed. |
Pull Request
Pull Request (PR) description
The is a breaking change that replaces the GitVersion 5 support with GitVersion 6. The schema for 6.3 is not compatible with 5.12.
GitVersion 6 does no longer support zero-padded versions like
3.0.1-preview0001, instead it looks like3.0.1-preview.1(FullSemVer). To be compatible with NuGet 2.0 (PowerShell, Chocolatey), the build taskGitVersiondoes the padding for pre-releases.References:
Added
GitVersion.ymlconfig file.GitVersion.Get-SamplerBuildVersionto be compatible with GitVersion 6.Get-SamplerBuildVersionPester tests.README.md.Changed
Manual Deployment.GitVersion.ymlconfig file to work with GitVersion 6.Task list
build.ps1 -ResolveDependency).This change is