-
Notifications
You must be signed in to change notification settings - Fork 0
upgrade messages_ja.json #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fix the URL of kustomize
Update Dev docs
Revert "Update Dev docs"
kobaji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
リソースの種類(Namespace, Task等)は、大文字始まりで統一した方が良いと思いました。英語が小文字始まりだとしても。
確かに日本語の表記で普通大文字始まりですね。こちらは修正します。
→修正を確認しました。この点に関して追加指摘はありません。
今後コミットが発生した場合、必要に応じて差分の英単語も確認するようにします。
kobaji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submitできていなかったです。すみません。
kobaji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submit
kobaji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
追加ですみません。句点「。」をなくしましょう。
|
本日のWebUIによるレビュー時、小林のAIになっていたものです。 作業履歴
|
yamaken1343
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
すべてResolveしました。作成、修正お疲れ様でした! |
load messages_ja.json file to translations file branch
Changes
upgarde messages_ja.json