PR feedback: Folder FromFile/FromFolder

Author: MrLuje

src/FSharpLint.Client/LSPFSharpLintService.fs

@@ -150,7 +150,7 @@ let private getFolderFor filePath (): Result<Folder, FSharpLintServiceError> =
     let handleFile filePath =
         if not (isPathAbsolute filePath) then
             Error FSharpLintServiceError.FilePathIsNotAbsolute
-        else match Folder.From filePath with
+        else match Folder.FromFile filePath with
              | None -> Error FSharpLintServiceError.FileDoesNotExist
              | Some folder -> Ok folder
 

src/FSharpLint.Client/LSPFSharpLintServiceTypes.fs

@@ -27,16 +27,21 @@ type FSharpLintVersion = FSharpLintVersion of string
 type FSharpLintExecutableFile = FSharpLintExecutableFile of File
 type Folder = private Folder of string 
 with 
-    static member From (filePath: string) =
+    static member FromFile (filePath: string) =
         if File.Exists(filePath) then 
-            // Path.GetFullPath to resolve path like /foo/bar/../baz
-            let folder = ((filePath |> Path.GetFullPath |> FileInfo).Directory)
+            let folder = (FileInfo filePath).Directory
             if folder.Exists then
                 folder.FullName |> Folder |> Some
             else
                 None
         else
             None
+    static member FromFolder (folderPath: string) =
+        if Directory.Exists(folderPath) then 
+            let folder = DirectoryInfo folderPath
+            folder.FullName |> Folder |> Some
+        else
+            None
     static member Unwrap(Folder f) = f
 
 [<RequireQualifiedAccess>]

src/FSharpLint.Client/LSPFSharpLintServiceTypes.fsi

@@ -19,7 +19,8 @@ type FSharpLintExecutableFile = FSharpLintExecutableFile of File
 
 type Folder = private Folder of string
 with
-    static member From: string -> Folder option
+    static member FromFile: string -> Folder option
+    static member FromFolder: string -> Folder option
     static member Unwrap: Folder -> string
 
 [<RequireQualifiedAccess>]