fix more rules

Author: MrLuje

src/FSharpLint.Client/Contracts.fs

@@ -23,7 +23,7 @@ type FSharpLintResponse = {
     Result : FSharpLintResult
 }
 
-type FSharpLintService =
+type IFSharpLintService =
     interface
         inherit IDisposable
 

src/FSharpLint.Client/Contracts.fsi

@@ -22,7 +22,7 @@ type FSharpLintResponse = {
     Result : FSharpLintResult
 }
 
-type FSharpLintService =
+type IFSharpLintService =
     inherit System.IDisposable
 
     abstract VersionAsync: VersionRequest * ?cancellationToken: CancellationToken -> Task<FSharpLintResponse>

src/FSharpLint.Client/FSharpLintToolLocator.fs

@@ -58,7 +58,7 @@ let private startProcess (ps: ProcessStartInfo) : Result<Process, ProcessStartEr
 
 let private runToolListCmd (workingDir: Folder) (globalFlag: bool) : Result<string list, DotNetToolListError> =
     let ps = ProcessStartInfo("dotnet")
-    ps.WorkingDirectory <- Folder.unwrap workingDir 
+    ps.WorkingDirectory <- Folder.Unwrap workingDir 
     ps.EnvironmentVariables.["DOTNET_CLI_UI_LANGUAGE"] <- "en-us" //ensure we have predictible output for parsing
 
     let toolArguments = 
@@ -198,7 +198,7 @@ let createFor (startInfo: FSharpLintToolStartInfo) : Result<RunningFSharpLintToo
         | FSharpLintToolStartInfo.LocalTool(workingDirectory: Folder) ->
             ProcessStartInfo(
                 FileName = "dotnet",
-                WorkingDirectory = Folder.unwrap workingDirectory,
+                WorkingDirectory = Folder.Unwrap workingDirectory,
                 Arguments = $"{FSharpLintToolName} --daemon")
         | FSharpLintToolStartInfo.GlobalTool ->
             let userProfile = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)
@@ -223,9 +223,12 @@ let createFor (startInfo: FSharpLintToolStartInfo) : Result<RunningFSharpLintToo
 
     match startProcess processStart with
     | Ok daemonProcess ->
+        // fsharplint:disable-next-line RedundantNewKeyword
         let handler = new HeaderDelimitedMessageHandler(
             daemonProcess.StandardInput.BaseStream,
             daemonProcess.StandardOutput.BaseStream)
+            
+        // fsharplint:disable-next-line RedundantNewKeyword
         let client = new JsonRpc(handler)
 
         do client.StartListening()

src/FSharpLint.Client/LSPFSharpLintService.fs

@@ -150,7 +150,7 @@ let private getFolderFor filePath (): Result<Folder, FSharpLintServiceError> =
     let handleFile filePath =
         if not (isPathAbsolute filePath) then
             Error FSharpLintServiceError.FilePathIsNotAbsolute
-        else match Folder.from filePath with
+        else match Folder.From filePath with
              | None -> Error FSharpLintServiceError.FileDoesNotExist
              | Some folder -> Ok folder
 
@@ -236,7 +236,7 @@ type LSPFSharpLintService() =
     let cts = new CancellationTokenSource()
     let agent = createAgent cts.Token
 
-    interface FSharpLintService with
+    interface IFSharpLintService with
         member this.Dispose() =
             if not cts.IsCancellationRequested then
                 agent.PostAndReply Reset |> ignore

src/FSharpLint.Client/LSPFSharpLintService.fsi

@@ -1,6 +1,6 @@
 module FSharpLint.Client.LSPFSharpLintService
 
 type LSPFSharpLintService =
-    interface Contracts.FSharpLintService
+    interface Contracts.IFSharpLintService
 
     new: unit -> LSPFSharpLintService

src/FSharpLint.Client/LSPFSharpLintServiceTypes.fs

@@ -27,7 +27,7 @@ type FSharpLintVersion = FSharpLintVersion of string
 type FSharpLintExecutableFile = FSharpLintExecutableFile of File
 type Folder = private Folder of string 
 with 
-    static member from (filePath: string) =
+    static member From (filePath: string) =
         if File.Exists(filePath) then 
             // Path.GetFullPath to resolve path like /foo/bar/../baz
             let folder = ((filePath |> Path.GetFullPath |> FileInfo).Directory)
@@ -37,7 +37,7 @@ with
                 None
         else
             None
-    static member unwrap(Folder f) = f
+    static member Unwrap(Folder f) = f
 
 [<RequireQualifiedAccess>]
 type FSharpLintToolStartInfo =

src/FSharpLint.Client/LSPFSharpLintServiceTypes.fsi

@@ -19,8 +19,8 @@ type FSharpLintExecutableFile = FSharpLintExecutableFile of File
 
 type Folder = private Folder of string
 with
-    static member from: string -> Folder option
-    static member unwrap: Folder -> string
+    static member From: string -> Folder option
+    static member Unwrap: Folder -> string
 
 [<RequireQualifiedAccess>]
 type FSharpLintToolStartInfo =

src/FSharpLint.Console/Program.fs

@@ -92,6 +92,7 @@ let private start (arguments:ParseResults<ToolArgs>) (toolsPath:Ionide.ProjInfo.
         ()
 
     if arguments.Contains ToolArgs.Daemon then
+        // fsharplint:disable-next-line RedundantNewKeyword
         let daemon = new FSharpLintDaemon(Console.OpenStandardOutput(), Console.OpenStandardInput())
         AppDomain.CurrentDomain.ProcessExit.Add(fun _ -> (daemon :> IDisposable).Dispose())
 

tests/FSharpLint.Client.Tests/TestClient.fs

@@ -7,6 +7,8 @@ open Contracts
 open LSPFSharpLintService
 open LSPFSharpLintServiceTypes
 
+// fsharplint:disable RedundantNewKeyword
+
 let (</>) x y = Path.Combine(x, y)
 
 let basePath = TestContext.CurrentContext.TestDirectory </> ".." </> ".." </> ".." </> ".." </> ".."
@@ -37,7 +39,7 @@ type ToolLocationOverride(toolStatus: ToolStatus) =
             if File.Exists tempFolder then
                 File.Delete tempFolder
 
-let runVersionCall filePath (service: FSharpLintService) =
+let runVersionCall filePath (service: IFSharpLintService) =
     async {
         let request = 
             {
@@ -53,7 +55,7 @@ let TestDaemonNotFound() =
     using (new ToolLocationOverride(ToolStatus.NotAvailable)) <| fun _ ->
 
         let testHintsFile = basePath </> "tests" </> "FSharpLint.FunctionalTest.TestedProject" </> "FSharpLint.FunctionalTest.TestedProject.NetCore" </> "TestHints.fs"
-        let fsharpLintService: FSharpLintService = new LSPFSharpLintService() :> FSharpLintService
+        let fsharpLintService: IFSharpLintService = new LSPFSharpLintService() :> IFSharpLintService
         let versionResponse = runVersionCall testHintsFile fsharpLintService
 
         Assert.AreEqual(LanguagePrimitives.EnumToValue FSharpLintResponseCode.ErrToolNotFound, versionResponse.Code)
@@ -63,7 +65,7 @@ let TestDaemonVersion() =
     using (new ToolLocationOverride(ToolStatus.Available)) <| fun _ ->
 
         let testHintsFile = basePath </> "tests" </> "FSharpLint.FunctionalTest.TestedProject" </> "FSharpLint.FunctionalTest.TestedProject.NetCore" </> "TestHints.fs"
-        let fsharpLintService: FSharpLintService = new LSPFSharpLintService() :> FSharpLintService
+        let fsharpLintService: IFSharpLintService = new LSPFSharpLintService() :> IFSharpLintService
         let versionResponse = runVersionCall testHintsFile fsharpLintService
 
         match versionResponse.Result with
@@ -77,7 +79,7 @@ let TestFilePathShouldBeAbsolute() =
     using (new ToolLocationOverride(ToolStatus.Available)) <| fun _ ->
 
         let testHintsFile = ".." </> "tests" </> "FSharpLint.FunctionalTest.TestedProject" </> "FSharpLint.FunctionalTest.TestedProject.NetCore" </> "TestHints.fs"
-        let fsharpLintService: FSharpLintService = new LSPFSharpLintService() :> FSharpLintService
+        let fsharpLintService: IFSharpLintService = new LSPFSharpLintService() :> IFSharpLintService
         let versionResponse = runVersionCall testHintsFile fsharpLintService
 
         Assert.AreEqual(LanguagePrimitives.EnumToValue FSharpLintResponseCode.ErrFilePathIsNotAbsolute, versionResponse.Code)
@@ -87,7 +89,7 @@ let TestFileShouldExists() =
     using (new ToolLocationOverride(ToolStatus.Available)) <| fun _ ->
 
         let testHintsFile = basePath </> "tests" </> "FSharpLint.FunctionalTest.TestedProject" </> "FSharpLint.FunctionalTest.TestedProject.NetCore" </> "TestHintsOOOPS.fs"
-        let fsharpLintService: FSharpLintService = new LSPFSharpLintService() :> FSharpLintService
+        let fsharpLintService: IFSharpLintService = new LSPFSharpLintService() :> IFSharpLintService
         let versionResponse = runVersionCall testHintsFile fsharpLintService
 
         Assert.AreEqual(LanguagePrimitives.EnumToValue FSharpLintResponseCode.ErrFileNotFound, versionResponse.Code)