Skip to content

Conversation

@amielnoy
Copy link

@amielnoy amielnoy commented Jun 6, 2023

[options.entry_points]
console_scripts =

  • selector = pytest_diff_selector.main:run
  • selector = pytest_diff_selector.main:main

this is the chane i made!
please test and merge

 [options.entry_points]
 console_scripts =
-    selector = pytest_diff_selector.main:run
+    selector = pytest_diff_selector.main:main
@amielnoy amielnoy changed the title fix fix entry point selector pytest_diff_selector.main:run-->pytest_diff_selector.main:main Jun 6, 2023
@@ -1,0 +1,32 @@
INSTALLING THE TOOL IN THE USER ENVIRONMENT:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are two readme files by mistake, can you move those instructions into README.md ?

Also try to stick to the markdown format

https://www.markdownguide.org/cheat-sheet/

Using headings and fenced code blocks

It would be nice that the readme change would be on its own commit, separated for the fix.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK
i will use a separate commit for the README.md
after applying usage and installation directions

@fruch
Copy link
Owner

fruch commented Jun 6, 2023

Try to amend the text to the commit, so it's title would be similar to the title of the PR

Anyhow you don't need to write the exact change in the commit description and title, one could see the diff. It's more helpful to write the reason for the change, for example pasting the backtrace/failure, so others can look it up if facing similar failure

@fruch
Copy link
Owner

fruch commented Jun 6, 2023

Looks like the CI checks precommit hooks are failing:

2023-06-06T18:51:28.1098931Z 
2023-06-06T18:51:28.1099107Z Traceback (most recent call last):
2023-06-06T18:51:28.1111112Z   File "/home/runner/.cache/pre-commit/repow928rqrp/py_env-python3.10/bin/black", line 8, in <module>
2023-06-06T18:51:28.1111816Z     sys.exit(patched_main())
2023-06-06T18:51:28.1112666Z   File "/home/runner/.cache/pre-commit/repow928rqrp/py_env-python3.10/lib/python3.10/site-packages/black/__init__.py", line 1423, in patched_main
2023-06-06T18:51:28.1113170Z     patch_click()
2023-06-06T18:51:28.1113823Z   File "/home/runner/.cache/pre-commit/repow928rqrp/py_env-python3.10/lib/python3.10/site-packages/black/__init__.py", line 1409, in patch_click
2023-06-06T18:51:28.1114244Z     from click import _unicodefun

I'm guessing black needs to be updated to work with newer click

Again I'll suggest doing such a change/fix on its own commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants