fix: update xauth on reboot/change #4
Merged
+226
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Ketelsen <bketelsen@gmail.com>
Signed-off-by: Brian Ketelsen <bketelsen@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the xauthority device mount in Igloo containers becomes stale when XWayland restarts and creates a new xauthority file with a different path. The fix adds functionality to detect and update the xauthority device mount on each igloo enter command.
Key changes:
- Added device management methods to check, retrieve, and update xauthority mounts
- Integrated xauthority update check into the container enter workflow
- Added comprehensive unit tests for the new functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/incus/client.go | Added RemoveDevice, DeviceExists, GetDeviceSource, and UpdateXauthority methods to handle dynamic xauthority file path changes |
| internal/incus/client_test.go | Added comprehensive unit tests covering UpdateXauthority behavior with no file, existing file, and custom XAUTHORITY paths |
| cmd/enter.go | Integrated UpdateXauthority call before entering container, with non-fatal warning on failure |
| TODO.md | New file documenting known bugs (including the xauthority issue being fixed) and future feature ideas |
Signed-off-by: Brian Ketelsen <bketelsen@gmail.com>
Signed-off-by: Brian Ketelsen <bketelsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.