suite.tests.mk: always regenerate Kyuafile #1879
Conversation
|
Does this fix the problem where alternating incremental builds with |
When a -DWITH_XXX or -DWITHOUT_XXX option is changed between two make invocations, Kyuafiles that are conditionally dependent on these options do not get regenerated. This results in unusuable Kyuafiles that list testcases that are nonexistent in an installed world. Since it is relatively inexpensive to generate Kyuafiles, just generate them unconditionally. Tested by running two consecutive incremental builds, one -DWITH_ZFS_TESTS and one -DWITHOUT_ZFS_TESTS. Verified that in the first case, `kyua list -k /usr/tests/Kyuafile` shows the ZFS tests and in the second case, those tests are not listed. Signed-off-by: Siva Mahadevan <me@svmhdvn.name> Sponsored by: The FreeBSD Foundation
svmhdvn
force-pushed
the
push-onzmxmnuonsm
branch
from
e282c53 to
1d4905a
Compare
svmhdvn
changed the title
|
I think v2 shows a better fix for this issue. The previous commit was wrong. Does this seem reasonable? I tested your observation and can confirm that it was a problem prior to my patch, and now it is fixed with my patch. |
Hum, but now we will regenerate kyuafiles even if nothing changed, which isn't really desirable either. https://reviews.freebsd.org/D52011 might be a better solution in the absence of meta mode. |
2 participants
When a -DWITH_XXX or -DWITHOUT_XXX option is changed between two make invocations,
Kyuafiles that are conditionally dependent on these options do not get regenerated.
This results in unusuable Kyuafiles that list testcases that are nonexistent in an
installed world.
Since it is relatively inexpensive to generate Kyuafiles, just generate them
unconditionally.
Tested by running two consecutive incremental builds, one -DWITH_ZFS_TESTS and
one -DWITHOUT_ZFS_TESTS. Verified that in the first case,
kyua list -k /usr/tests/Kyuafileshows the ZFS tests and in the second case,those tests are not listed.