-
Notifications
You must be signed in to change notification settings - Fork 31
Improvements #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuripourre
wants to merge
43
commits into
fpsunflower:master
Choose a base branch
from
Harium:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improvements #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 10x speedup with big area lights)
… such small meshes (about 20 % improvement on scenes with large flat rectangular surfaces)
Extract Parameters
Fix tests
Create instanceParameter on setup geometries
…r into fluent API
Convenient methods
Add self-intersection bias parameter based on k-matsuzaki's repository
|
I would love these improvements but this project appears to be long dead. Has anyone created a fork of it that they're maintaining? |
Author
|
@timmattison I created a fork and glued all the available bug fixes, also did some refactoring. But I am not currently maintaining it. If you want to contribute I could definitely review and merge PRs to my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First of all, I would like to thank this great (and well-written) project. I learnt a lot from reading those codes.
I know this repository is kind of abandoned but if someone is still interested in development, those commits might be useful.
@karelp did a great work mavenizing, cleaning and improving some parts of the project.
I did some refactoring extracting classes from the original parser adding a way to render procedural scenes (or maybe add new parsers).
@fpsunflower
Please take a look. It would be nice to have it in the main repository.