-
Notifications
You must be signed in to change notification settings - Fork 152
Fixes Autoscroll on Sessions page #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
Conversation
- Updated pretalx-schedule.min.js with new widget supporting disable-auto-scroll - Added disable-auto-scroll attribute to schedule.html pretalx-schedule element - Fixed template syntax by putting all Django template tags on single lines The widget changes are from fossasia/eventyay-talk-schedule fix/disable-auto-scroll branch. Fixes fossasia#1430
Reviewer's GuideAdds support for a disable-auto-scroll attribute in the pretalx schedule widget and wires it up in the agenda schedule template while cleaning up Django template formatting and tag usage. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The
pretalx-scheduleelement is now on a single long line with many attributes, which makes future diffs and reviews harder; consider keeping the tag itself on one line but wrapping attributes across multiple lines for readability while still respecting the template-engine constraint you’re fixing. - The new
disable-auto-scrollattribute is always enabled; if there are scenarios where auto-scroll is still desirable, consider making this behavior conditional (e.g., driven by a view flag or template variable) instead of hard-coded.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `pretalx-schedule` element is now on a single long line with many attributes, which makes future diffs and reviews harder; consider keeping the tag itself on one line but wrapping attributes across multiple lines for readability while still respecting the template-engine constraint you’re fixing.
- The new `disable-auto-scroll` attribute is always enabled; if there are scenarios where auto-scroll is still desirable, consider making this behavior conditional (e.g., driven by a view flag or template variable) instead of hard-coded.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an auto-scroll issue on the schedule page by updating the pretalx-schedule widget to support a disable-auto-scroll attribute and applying it in the template. The changes include both widget updates (compiled JavaScript) and template formatting improvements.
- Updated the pretalx-schedule widget to support
disableAutoScrollprop that prevents auto-scrolling to current time on page load - Added
disable-auto-scrollattribute to the<pretalx-schedule>element in the schedule template - Cleaned up template formatting by normalizing Django tags and indentation
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/eventyay/static/agenda/js/pretalx-schedule.min.js |
Added disableAutoScroll prop to schedule components and integrated it into scroll logic to prevent automatic scrolling when the attribute is present |
app/eventyay/agenda/templates/agenda/schedule.html |
Added disable-auto-scroll attribute to the widget element and cleaned up template formatting with consistent indentation and single-line Django tags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There is a UI issue on the sessions page, I will fix it with a new pr once this is merged, dont want to add that into this for it to be clean and not confusing to the changes |
Screen.Recording.2025-12-06.at.1.21.30.AM.mov
Fix Schedule Page Auto-Scroll Issue (Proper Widget Fix)
This PR properly fixes the jarring auto-scroll when navigating to the schedule page by updating the pretalx-schedule widget to support a
disable-auto-scrollattribute.Fixes #1430
Changes
1. Updated Widget (
pretalx-schedule.min.js)fossasia/eventyay-talk-schedulewith newdisable-auto-scrollprop2. Updated Template (
schedule.html)disable-auto-scrollattribute to<pretalx-schedule>elementHow It Works
The widget now accepts a
disable-auto-scrollattribute: