Use Tracy for error handling

[jtojnar]

Tracy produces much nicer error messages and allows us to get rid of F3.

The version supporting PHP 5.6 unfortunately produces warnings on PHP 8.0. Also until Tracy 2.9 (for PHP 7.3+) starts a session, which conflicts with session_set_cookie_params.

• we need to convince tracy to log even in dev mode – likely by subclassing
• Find out why ajax requests do not appear in tracy panel seems to work with 2.9
• integrate PDO into tracy panel can be done later

[netlify]

✅ Deploy Preview for selfoss canceled.

Name	Link
🔨 Latest commit	34fff94
🔍 Latest deploy log	https://app.netlify.com/projects/selfoss/deploys/694c997e6be7d100080e079f

[jtojnar]

Okay, I went over the code again and re-tested it and it appears to work as expected:

• When accessing an endpoint
  • unless non-HTML Content-type header is sent:
    • with debug=1, debugging bluescreen is shown
    • with debug=0, error 500 is shown
      • if log file is not writeable, the !$logged variant of the message will be shown
  • otherwise, error 500 with empty body is sent
• when running cliupdate.php
  • with debug=1, trace is shown
  • with debug=0, only error message is shown and user is prompted to see logs

Exception throwing patch

The relevant hunk was applied when testing individual endpoint/script:

diff --git a/cliupdate.php b/cliupdate.php
index 19bcbaac..795e91f1 100644
--- a/cliupdate.php
+++ b/cliupdate.php
@@ -12,6 +12,7 @@ require __DIR__ . '/src/common.php';
 $loader = $container->get(helpers\ContentLoader::class);
 $updateVisitor = new class implements UpdateVisitor {
     public function started(int $count): void {
+        throw new Exception('CLI error');
     }
 
     public function sourceUpdated(): void {
diff --git a/src/controllers/About.php b/src/controllers/About.php
index 0a3847be..3d806faa 100644
--- a/src/controllers/About.php
+++ b/src/controllers/About.php
@@ -24,6 +24,7 @@ final readonly class About {
      * json
      */
     public function about(): never {
+        throw new \Exception('API error');
         $wallabag = !empty($this->configuration->wallabag) ? [
             'url' => $this->configuration->wallabag, // string
             'version' => $this->configuration->wallabagVersion, // int
diff --git a/src/controllers/Index.php b/src/controllers/Index.php
index 4c862037..1b6d7f81 100644
--- a/src/controllers/Index.php
+++ b/src/controllers/Index.php
@@ -39,6 +39,7 @@ final readonly class Index {
         $options = $_GET;
 
         if (!$this->view->isAjax()) {
+            throw new \Exception('HTML error');
             $home = BASEDIR . '/public/index.html';
             if (!file_exists($home) || ($homeData = file_get_contents($home)) === false) { // For PHPStan: Error will be already handled by global error handler.
                 http_response_code(500);
@@ -54,6 +55,7 @@ final readonly class Index {
 
         $this->authentication->ensureCanRead();
 
+        throw new \Exception('AJAX error');
         // load tags
         $tags = $this->tagsDao->getWithUnread();