Grcc fixes #761
Open
Grcc fixes #761
+495
−463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manual (currently) states that "The coupling constant is either the number 1, or a (product of) symbol(s) to an integer power. If the symbols have not been declared before they will be declared during the reading of the vertex declaration.". However, "1" causes empty arguments to be printed in node_ functions, numbers other than "1" are accepted, and it doesn't work at all for vertices with four or more legs. Since the user can modify the couplings as they wish after diagram generation with replace_ etc, demand symbols in the Vertex definition.
These are not accepted by grcc.cc anyway, so print a more useful error and terminate.
If compiling as part of FORM, call FORM's Terminate rather than exit.
Collaborator
|
As far as I understand, Ideally, the lock should be taken by the caller at a higher level, but doing so would likely be too cumbersome and undermine the goal of keeping this a thin wrapper. |
Collaborator
Author
|
Ah yes, I forgot to include the locks. I'll add them in. There are also various error messages which are split over multiple calls of fprintf, where the first has no newline, which via MesPrint will go onto multiple lines. This could be improved by consolidating them into a single function call, but maybe we don't care so much about the formatting, as along as the information is at least in the log file. |
When compiling under FORM, we can format the output with vsnprintf, and then just give the formatted string to MesPrint, such that it ends up in the FORM log file. When compiling without FORM, just forward the format string and the args to vfprintf, which prints them as previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few fixes for the (interface to) grcc.
TopologiesOnly_mode.,,in thenode_output, and anyway crashes for quartic vertices. The manual will need an update to reflect this, but it will be re-written as a separate PR.