Fix incorrect normalization for Singapore #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@floere it looks like RSpec on 3.0 is failing due to an unsatisfied Bundler version. https://github.com/floere/phony/actions/runs/19738706620/job/56556897761?pr=556 Not sure what action to take here. As a maintainer I would have dropped support for EOL Rubies, but this may not be what you want. So I won't take any action in this PR. It seems the changes are correct though as CI passes for all other versions. |
Contributor
Author
|
It looks like the build has been failing since 5 months, according to https://github.com/floere/phony/commits/master/. @floere are you ok if I remove support for Ruby 3.0? |
Owner
|
@weppos Yes, please! 🙏🏼 |
Merged
Owner
|
@weppos Thanks also for this clean MR! 🙏 Released in 3.0.1 🚀 |
Contributor
Author
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Singapore numbers have no trunk, but some numbers also start with 0. The current version is incorrectly stripping that digit.
Fixes #555
Blocked by #557