EDM-3069 patch credentials only if changed #453
Draft
+89
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
celdrake
force-pushed
the
EDM-3069-patch-credentials-only-if-changed
branch
from
5a5a811 to
971480f
Compare
celdrake
force-pushed
the
EDM-3069-patch-credentials-only-if-changed
branch
from
971480f to
b953478
Compare
celdrake
commented
Jan 13, 2026
| if (ociRepoSpec.skipServerVerification !== undefined) { | ||
| patches.push({ op: 'remove', path: '/spec/skipServerVerification' }); | ||
| } | ||
| if (ociRepoSpec.scheme) { |
Collaborator
Author
There was a problem hiding this comment.
scheme and accessMode are not part of the "additionalSettings" field, they are mandatory though they have defauts. S this would have been resetting to the defaults incorrectly.
celdrake
force-pushed
the
EDM-3069-patch-credentials-only-if-changed
branch
from
b953478 to
167723e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the users would modify an OCI registry, the credentials were incorrectly included (as they are masked)
The same thing is likely happening for other repository types, but there's a bug in the API and we can't set credentials on those repositories to test it properly. Marking as Draft until the backend bug is fixed.