EDM-2865: Upgrade to Patternfly v6 #448
Conversation
|
Important Review skippedToo many files! 6 files out of 156 files are above the max files limit of 150. You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| <> | ||
| <Label color="purple">{getAssignmentTypeLabel(roleAssignment.type, t)}</Label> | ||
| <LabelGroup className="pf-v5-u-mt-sm"> | ||
| <LabelGroup className="pf-v6-u-ml-sm"> |
There was a problem hiding this comment.
it was missing horizontal spacing
celdrake
force-pushed
the
upgrade-pf6
branch
from
1cae719 to
62315d3
Compare
celdrake
force-pushed
the
upgrade-pf6
branch
from
f2249ee to
516834a
Compare
jgyselov
left a comment
jgyselov
left a comment
There was a problem hiding this comment.
Just one potential little problem. 🙂
As for the PF6 updates, I didn't see any issues in the code or the UI (the parts that I managed to interact with).
| if (!trimmed) { | ||
| return true; | ||
|
|
||
| if (!/^[0-9]+$/.test(cpu)) { |
There was a problem hiding this comment.
This change results in the suggested value 0.4 being invalid. Not sure what's correct here but either the validation or the helper text needs to change.
There was a problem hiding this comment.
Good catch, thanks!
This was so that 3433asf would be considered an invalid value, but I forgot about the fractions. I'll double check that it's enough to add the dot to the regular expression.
Could be part of another PR but I guess since I was testing all fields etc I just noticed that.
Great, thanks! The "Devices" area is a bit tricker to test because you need to either enroll a device (it can be done easily in the backend project doing Let me know if you'd want to proceed further or you're satisfied with what you covered. |
I managed to simulate a fleet so I could see the tables, the detail pages, and the edit forms etc. It all looked fine and the changes in the code weren't complicated anyway. I think you're good here. |
2 participants
Yet to be done: review if the YAML editor is aligned with newer versions.