Skip to content

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Dec 18, 2025

The button for reloading the organization will not succeed while the user stays logged in, so it's best to remove it.

We only keep it for the case where there's an unknown error which may be transient.

Summary by CodeRabbit

  • New Features

    • Added a user notification prompting users to log out and log back in to regain access in specific scenarios.
  • Bug Fixes

    • Reload action now appears only when organizations are available, clarifying when users can retry loading content.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Walkthrough

Added a new English translation string and updated OrganizationSelector to show that message when users lack organization access and to render the Reload button only when organizations exist.

Changes

Cohort / File(s) Summary
Translation Addition
libs/i18n/locales/en/translation.json
Added top-level translation key "You will need to log out and log in again to access the application." with the same value.
UI Component Update
libs/ui-components/src/components/common/OrganizationSelector.tsx
Inserted informational text using the new translation in the "no access" branch. Restricted Reload button rendering to only display when organizations are present; applied this condition in both empty and error states.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: conditionally showing the reload organizations button only when it can succeed, matching the PR's core objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d782277 and d0f7967.

📒 Files selected for processing (2)
  • libs/i18n/locales/en/translation.json
  • libs/ui-components/src/components/common/OrganizationSelector.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • libs/ui-components/src/components/common/OrganizationSelector.tsx
  • libs/i18n/locales/en/translation.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: integration-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake force-pushed the reload-organizations-only-when-possible branch from d782277 to bd31d94 Compare January 13, 2026 09:43
@celdrake celdrake force-pushed the reload-organizations-only-when-possible branch from bd31d94 to d0f7967 Compare January 13, 2026 09:44
@celdrake celdrake merged commit a912d7c into flightctl:main Jan 13, 2026
6 checks passed
@celdrake celdrake deleted the reload-organizations-only-when-possible branch January 13, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants