Skip to content

Replace ast.Ellipsis with ast.Constant #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabaff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace ast.Ellipsis with ast.Constant #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pscript/commonast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
if docheck:
assert not hasattr(self, "__dict__"), "Nodes must have __slots__"
assert self.__class__ is not Node, "Node is an abstract class"
for name, val in zip(names, args):

Check failure on line 94 in pscript/commonast.py

View workflow job for this annotation

GitHub Actions / Linting

Ruff (B905) 

pscript/commonast.py:94:30: B905 `zip()` without an explicit `strict=` parameter
assert not isinstance(val, ast.AST)
if name == "name":
assert isinstance(val, (str, NoneType)), "name not a string"
Expand All @@ -110,7 +110,7 @@
isinstance(val, list) and all(isinstance(n, Node) for n in val)
)
# Assign
for name, val in zip(names, args):

Check failure on line 113 in pscript/commonast.py

View workflow job for this annotation

GitHub Actions / Linting

Ruff (B905) 

pscript/commonast.py:113:26: B905 `zip()` without an explicit `strict=` parameter
setattr(self, name, val)

def tojson(self, indent=2):
Expand Down Expand Up @@ -1032,7 +1032,7 @@

def _convert_index_like(self, n):
c = self._convert
if isinstance(n, (ast.Slice, ast.Index, ast.ExtSlice, ast.Ellipsis)):
if isinstance(n, (ast.Slice, ast.Index, ast.ExtSlice, ast.Constant)):
return c(n) # Python < 3.8 (and also 3.8 on Windows?)
elif isinstance(n, ast.Tuple):
assert isinstance(n, ast.Tuple)
Expand Down
Loading