Skip to content

Conversation

@marcorudolphflex
Copy link
Contributor

@marcorudolphflex marcorudolphflex commented Jan 7, 2026

When loading data from batches with verbose=True, we currently flood the console with all the “Loading simulation from…” messages which is not wanted in this case.
Therefore, I fixed verbose=False for web.load in the batch scenario.


Note

Reduces noisy console output when iterating over batch results.

  • In BatchData.load_sim_data(), pass verbose=False to web.load() to suppress per-task “Loading simulation…” messages
  • Update CHANGELOG.md under Fixed to note restored original batch-load logging behavior

Written by Cursor Bugbot for commit 9b049ff. This will update automatically on new commits. Configure here.

Greptile Summary

This PR fixes excessive verbosity when loading batch simulation data by hardcoding verbose=False in the BatchData.load_sim_data() method.

Changes:

  • Modified tidy3d/web/api/container.py:627 to pass verbose=False instead of self.verbose to web.load()
  • Previously, when BatchData.verbose=True, each individual simulation load would print "Loading simulation from {path}", flooding the console with repetitive messages
  • The fix suppresses these per-simulation messages while preserving batch-level progress tracking

Impact:

  • Users will no longer see redundant "Loading simulation from..." messages for each task when iterating through batch results
  • Batch-level verbosity controls (progress bars, upload/download status) remain unaffected
  • This aligns with the expected behavior where verbose=True controls batch operations, not individual data loads

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is minimal, well-scoped, and directly addresses the reported issue. It only affects console output verbosity without changing any logic or behavior. The fix is a single-line change that hardcodes verbose=False when loading individual simulations from a batch, preventing console flooding while preserving all functionality.
  • No files require special attention

Important Files Changed

Filename Overview
tidy3d/web/api/container.py Changed verbose=self.verbose to verbose=False in BatchData.load_sim_data() to suppress individual "Loading simulation from..." messages when loading batch data

Sequence Diagram

sequenceDiagram
    participant User
    participant Batch
    participant BatchData
    participant web.load
    participant Console

    User->>Batch: run(verbose=True)
    Batch->>BatchData: load() with verbose=True
    Note over BatchData: BatchData.verbose = True
    
    loop For each task in batch
        User->>BatchData: __getitem__(task_name)
        BatchData->>BatchData: load_sim_data(task_name)
        BatchData->>web.load: load(verbose=False)
        Note over web.load: BEFORE: verbose=self.verbose<br/>AFTER: verbose=False
        alt verbose=False (AFTER fix)
            web.load-->>BatchData: Returns data silently
        else verbose=True (BEFORE fix)
            web.load->>Console: "Loading simulation from {path}"
            web.load-->>BatchData: Returns data with log message
        end
        BatchData-->>User: Returns simulation data
    end
    
    Note over User,Console: Fix prevents console flooding<br/>with repeated load messages
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@marcorudolphflex marcorudolphflex force-pushed the FXC-4704-reduce-verbosity-when-loading-data-from-batch branch from fbf4495 to ca94e78 Compare January 7, 2026 08:23
@yaugenst-flex
Copy link
Collaborator

Even though it's a tiny change I think this warrants a changelog entry.

@marcorudolphflex marcorudolphflex force-pushed the FXC-4704-reduce-verbosity-when-loading-data-from-batch branch from ca94e78 to 9b049ff Compare January 7, 2026 11:01
@marcorudolphflex marcorudolphflex added this pull request to the merge queue Jan 7, 2026
Merged via the queue into develop with commit 3f710b8 Jan 7, 2026
33 of 37 checks passed
@marcorudolphflex marcorudolphflex deleted the FXC-4704-reduce-verbosity-when-loading-data-from-batch branch January 7, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants