[snappy] added quality controls for snap and smooth #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature edge deduplication tolerance
piotrkluba
reviewed
Dec 24, 2025
Collaborator
piotrkluba
left a comment
piotrkluba
left a comment
There was a problem hiding this comment.
Few comments to improve consistency with other metrics
| le=1, | ||
| description="Error reduction factor. Used in combination with n_smooth_scale. Must be between 0 and 1.", | ||
| ) | ||
| zmetric_threshold: pd.NonNegativeFloat = pd.Field( |
Collaborator
There was a problem hiding this comment.
Do those parameters have maximum values? If so set maximum values using le or write a validator. Add option to disable using False
| "errorReduction": ( | ||
| quality_settings.error_reduction if quality_settings.error_reduction else 0 | ||
| ), | ||
| "zMetricThreshold": quality_settings.zmetric_threshold, |
Collaborator
There was a problem hiding this comment.
add values that disable those metrics using Literal[False]
| snappy.QualityMetrics(max_internal_skewness=-2 * u.deg) | ||
|
|
||
| snappy.QualityMetrics(max_boundary_skewness=23 * u.deg, max_internal_skewness=89 * u.deg) | ||
| with pytest.raises(pd.ValidationError): |
Collaborator
There was a problem hiding this comment.
Add "free" lines that will not throw an error to ensure normal usage is fine.
| "minTriangleTwist": -1, | ||
| "nSmoothScale": 4, | ||
| "errorReduction": 0.75, | ||
| "zMetricThreshold": 0.8, |
Collaborator
There was a problem hiding this comment.
If you allow turning off this metric through False, also change the values here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added quality controls for snap and smooth: zmetric (aka badness) an feature edge deduplication tolerance