added mass reading and test #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh that's embarrassing, we still have python 3.7 on the CI. Um, let me fix that on another branch. This looks great, thanks for adding this. I think this should work, I need to test it a bit. It's been a while since I looked at a FISPACT-II input file..... I have a few minor comments, I'll add inline. |
thomasms
reviewed
Apr 17, 2025
thomasms
reviewed
Apr 17, 2025
thomasms
reviewed
Apr 17, 2025
thomasms
reviewed
Apr 17, 2025
thomasms
reviewed
Apr 17, 2025
Member
I've fixed the CI now and testing on 3.8 <= python <= 3.12. |
thomasms
reviewed
Apr 18, 2025
Contributor
Author
|
Super super tests are passing. Sorry for all the changes |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to read in the MASS keyword and following element values from a fispact input file.
As proposed in the github discussions
#56