Skip to content

Conversation

@arai-a
Copy link

@arai-a arai-a commented Dec 23, 2025

Fixed #5731

This adds a button to the Marker Table settings bar, which shows a context menu that provides the following:

  • copy as plain text
  • copy as Markdown

(not sure if Markdown is actually necessary. If not, it can be simplified to just a single button that copies as plain text)

the plain text copies the table in the following style:

  Start  Duration                     Name  Details
 0.002s                   Process Priority  priority: BACKGROUND
 0.002s   unknown                    Awake
 0.002s  603.25us                 Runnable  TriggerPollJSSamplingOnMainThread - priority: Normal (4) task: 4d9c1b1537e9fcf80

the Markdown copies the table in the following style:

|   Start | Duration |                    Name | Details |
|--------:|---------:|------------------------:|---------|
|  0.002s |          |        Process Priority | priority: BACKGROUND |
|  0.002s |  unknown |                   Awake |  |
|  0.002s | 603.25us |                Runnable | TriggerPollJSSamplingOnMainThread - priority: Normal (4) task: 4d9c1b1537e9fcf80 |
copy-table

@arai-a arai-a requested a review from a team as a code owner December 23, 2025 12:34
@canova canova self-requested a review December 23, 2025 13:25
Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the idea of being able to copy the table!

One thing I noticed is that it is hanging for a long time if the table is huge and if there is no filtering applied to it. Normally, we virtualize this table, so it might look like we don't have a lot sometimes, but for large profile it might be too many marker lines.

Maybe we can have an upper limit like const MAX_COPY_ROWS = 10000, and show users a warning that the rest is ommitted. What do you think?;


lines.push([
data.start,
duration.replace(/μ/g, 'u'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we replace μ here? Are unicode chars a problem?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because "μ" is wider than other ASCII characters (at least for me) and that breaks the alignment of the table

this._getMarkerLabel = getMarkerLabel;
}

copyTable = (format: string) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this function inside src/profile-logic/marker-data.ts. I think this is a function that's worth extracting outside of the react component. (not the copy() call, but the table building logic)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is heavily tied to the MarkerTree class, which is local to MarkerTable component.
especially the marker handling, zeroAt, the column alignment etc are specific to the file and they depends on the memoization, and also the state map defined there.

So, the entire logic cannot be moved, and splitting a part of the logic will make it harder to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the Marker Table copyable as text

2 participants