Skip to content

Conversation

@Rawpower9
Copy link
Contributor

No description provided.

@Rawpower9 Rawpower9 requested a review from a team as a code owner January 7, 2025 03:54
@Rawpower9 Rawpower9 requested a review from chivesonions January 7, 2025 03:54
Copy link
Contributor

@mattsmithtaiko mattsmithtaiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve so we don't need to go back-and-forth on another review, but please address the comments first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file. This is from the MacOS filesystem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file's name inconsistent with the others? I.e., it doesn't start with welcome-to-. I don't have a strong preference on naming convention but let's make it consistent. Could also call each of them like design-welcome.md or design-landing.md since these are basically the welcome/landing pages from which you can navigate to other subpages.

@Rawpower9
Copy link
Contributor Author

added proposed changes (kept the welcome-to- convention for the landing pages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants