-
Notifications
You must be signed in to change notification settings - Fork 128
Remove extra iOS targets from GHA tests #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to optimize the GitHub Actions CI/CD pipeline by removing unnecessary iOS testing targets. By focusing on the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request streamlines the iOS testing configuration by removing several device targets from the GitHub Actions workflows. The changes in scripts/gha/print_matrix_configuration.py correctly remove ios_min, ios_latest, simulator_min, and simulator_latest from both the EXPANDED_KEY matrix and the TEST_DEVICES dictionary. The documentation in scripts/gha/test_simulator.py is also updated to reflect these removals. The changes are consistent and achieve the stated goal of simplifying the testing targets. The code is clean and I have no further suggestions.
❌ Integration test FAILEDRequested by @a-maurice on commit 62c772b
Add flaky tests to go/fpl-cpp-flake-tracker |
Description
Reduce iOS testing targets to just ios_target and simulator_target, as the Firebase Test Lab is primarily only supporting one version anymore, making the others unnecessary.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.