-
Notifications
You must be signed in to change notification settings - Fork 128
Update ios devices used by FTL #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration of iOS devices and their corresponding operating system versions used within the Firebase Testlab (FTL) runners. The changes ensure that the automated testing infrastructure leverages the most current and relevant iOS devices and software versions available, thereby maintaining up-to-date testing environments for continuous integration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the iOS devices and versions used for Firebase Test Lab (FTL) in the CI configuration. The ios_min devices are updated to a newer model and OS version, and ios_latest is updated to iphone16pro with a newer OS. These changes help keep the test device matrix current. My review includes one suggestion for the ios_latest configuration to consider maintaining device variety for better test coverage.
| "ios_latest": [ | ||
| {"type": "ftl", "device": "model=iphone15,version=18.0"}, | ||
| {"type": "ftl", "device": "model=iphone15pro,version=18.0"}, | ||
| {"type": "ftl", "device": "model=iphone16pro,version=18.3"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ios_latest configuration is being updated to a single device, iphone16pro. The previous configuration included two devices (iphone15 and iphone15pro), which provided more variety in testing since a device is chosen randomly for each run. This change reduces the diversity of devices for the 'latest' category. If other recent iPhone models are available on FTL with a compatible OS version, please consider adding them to this list to broaden the test coverage.
Integration test with FLAKINESS (succeeded after retry)Requested by @a-maurice on commit 9fc5959
Add flaky tests to go/fpl-cpp-flake-tracker |
Description
Update the iOS devices and versions used by the Firebase Testlab runners, based on what is currently available.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.