Skip to content

Conversation

@a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Update the iOS devices and versions used by the Firebase Testlab runners, based on what is currently available.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Dec 9, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the configuration of iOS devices and their corresponding operating system versions used within the Firebase Testlab (FTL) runners. The changes ensure that the automated testing infrastructure leverages the most current and relevant iOS devices and software versions available, thereby maintaining up-to-date testing environments for continuous integration.

Highlights

  • iOS Minimum Device Updates: The ios_min configuration for Firebase Testlab (FTL) has been updated. The iphone13pro running iOS 15.7 was replaced with iphone14pro running iOS 16.6, and the iphone8 was updated from iOS 15.7 to 16.6.
  • iOS Latest Device Updates: The ios_latest configuration for FTL has been updated. The previous iphone15 and iphone15pro devices, both on iOS 18.0, have been replaced with a single iphone16pro running iOS 18.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the iOS devices and versions used for Firebase Test Lab (FTL) in the CI configuration. The ios_min devices are updated to a newer model and OS version, and ios_latest is updated to iphone16pro with a newer OS. These changes help keep the test device matrix current. My review includes one suggestion for the ios_latest configuration to consider maintaining device variety for better test coverage.

"ios_latest": [
{"type": "ftl", "device": "model=iphone15,version=18.0"},
{"type": "ftl", "device": "model=iphone15pro,version=18.0"},
{"type": "ftl", "device": "model=iphone16pro,version=18.3"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ios_latest configuration is being updated to a single device, iphone16pro. The previous configuration included two devices (iphone15 and iphone15pro), which provided more variety in testing since a device is chosen randomly for each run. This change reduces the diversity of devices for the 'latest' category. If other recent iPhone models are available on FTL with a compatible OS version, please consider adding them to this list to broaden the test coverage.

@a-maurice a-maurice merged commit 9fc5959 into main Dec 9, 2025
29 of 45 checks passed
@a-maurice a-maurice deleted the am-ios_runners branch December 9, 2025 03:05
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit 9fc5959
Last updated: Mon Dec 8 21:30 PST 2025
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(2 failed tests)  WriteBatchTest.TestCannotUpdateNonexistentDocuments
  WriteBatchTest.TestWriteTheSameServerTimestampAcrossWrites

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Dec 9, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant