Skip to content

Conversation

@CorieW
Copy link
Member

@CorieW CorieW commented Jul 10, 2025

No description provided.

Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR releases version 0.2.4 of the Firestore Send Email extension by fixing the TTL “week” calculation, adding support for custom email headers, and updating documentation and changelog.

  • Fixed week interval in getExpireAt to multiply days by 7 and added a default error case.
  • Added headers field to the email delivery options.
  • Bumped extension version and updated docs (README, PREINSTALL) and CHANGELOG.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
functions/src/index.ts Corrected TTL “week” logic, added default case, and support for headers
extension.yaml Version bumped from 0.2.3 to 0.2.4
README.md Added “Using custom headers” section with JSON example
PREINSTALL.md Added “Using custom headers” section with JSON example
CHANGELOG.md Added v0.2.4 entries for header support and TTL fix
Comments suppressed due to low confidence (3)

firestore-send-email/functions/src/index.ts:176

  • New headers support was added but no tests appear to cover custom headers. Consider adding unit or integration tests to verify headers are passed correctly.
      headers: payload?.headers,

firestore-send-email/README.md:44

  • The example JSON has a trailing comma after the last property, which isn’t valid JSON. Removing the trailing comma will avoid confusion for users.
    "X-Another-Header": "AnotherValue",

firestore-send-email/PREINSTALL.md:36

  • The example JSON has a trailing comma after the last header entry, which is not valid JSON. Please remove the trailing comma.
    "X-Another-Header": "AnotherValue",

@CorieW CorieW merged commit 1c828d1 into master Jul 10, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants