Skip to content

Conversation

@Nushio
Copy link
Contributor

@Nushio Nushio commented May 27, 2025

I just noticed that this feature was removed, and wanted to contribute a quick fix.

@google-cla
Copy link

google-cla bot commented May 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Nushio
Copy link
Contributor Author

Nushio commented May 27, 2025

I've signed the CLA

Screenshot 2025-05-27 at 5 01 27 PM

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores support for custom email headers in the Firestore email sending extension by reintroducing the missing headers field and updating documentation accordingly.

  • Restores the headers property in the mail options in index.ts.
  • Bumps the extension version to 0.2.4 in extension.yaml.
  • Updates documentation and changelog to reflect this new feature.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
firestore-send-email/functions/src/index.ts Adds the headers field to email payload to support custom headers.
firestore-send-email/extension.yaml Updates the extension version.
firestore-send-email/README.md Adds a section on using custom headers with example JSON.
firestore-send-email/CHANGELOG.md Documents the addition of the headers field and updates the version.

@cabljac
Copy link
Contributor

cabljac commented May 30, 2025

Hi, can you run npm run generate-readme in the firestore-send-email/functions directory

@Nushio
Copy link
Contributor Author

Nushio commented May 30, 2025

I ran it but it removes the blurb I wrote about using Custom Headers.

Where should I place that instead? PREINSTALL.md ?

Edit: Done

@Nushio
Copy link
Contributor Author

Nushio commented Jun 16, 2025

Any blockers on this PR?

@cabljac
Copy link
Contributor

cabljac commented Jun 17, 2025

Hi! No blockers, just finding time to prioritise it. Sorry for the wait.

@cabljac cabljac requested a review from HassanBahati June 17, 2025 15:18
@Nushio
Copy link
Contributor Author

Nushio commented Jun 18, 2025

Thanks, no problem. Just wondering if there was something else missing on my end.

@cabljac cabljac requested review from CorieW and removed request for HassanBahati July 2, 2025 08:44
Copy link
Member

@CorieW CorieW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works fine
image

Just needs conflicts resolved

@Nushio
Copy link
Contributor Author

Nushio commented Jul 4, 2025

Thank you! I'll work on these tomorrow morning!

@Nushio
Copy link
Contributor Author

Nushio commented Jul 4, 2025

@CorieW If I did things right, it should be mergeable now.

I used version 0.2.5 as it was the next number in the list.

@cabljac
Copy link
Contributor

cabljac commented Jul 8, 2025

Hi! lgtm, i'll try and get this released this week.

@CorieW
Copy link
Member

CorieW commented Jul 10, 2025

Closing to make some minor adjustments before release in #2463

Thank you for your PR!

@CorieW CorieW closed this Jul 10, 2025
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jul 10, 2025
@Nushio
Copy link
Contributor Author

Nushio commented Jul 11, 2025

Super discouraging, but alright. :-/

@cabljac
Copy link
Contributor

cabljac commented Jul 11, 2025

Apologies @Nushio, this was miscommunication on my part. I'll see what I can do about ensuring some attribution is recognised

@cabljac
Copy link
Contributor

cabljac commented Jul 11, 2025

Hi @Nushio I've created a PR to correctly attribute you:

#2471

Apologies again, your contribution is very appreciated!

@Nushio
Copy link
Contributor Author

Nushio commented Jul 11, 2025

Thank you!

@CorieW
Copy link
Member

CorieW commented Jul 11, 2025

Sorry about this, @Nushio

I hope this experience doesn't discourage you. We really appreciate your contributions and want to support and encourage all contributors.

Once again, thank you for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants