Skip to content

Conversation

@cabljac
Copy link
Contributor

@cabljac cabljac commented Apr 22, 2025

No description provided.

cabljac added 2 commits April 17, 2025 15:59
* fix(firestore-bigquery-export): correct database region param

* fix(firestore-shorten-urls-bitly): fix database region

* fix(firestore-shorten-urls-bitly): make db region mutable
@cabljac cabljac requested a review from Copilot April 22, 2025 07:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR releases version 0.2.1 of both the firestore-shorten-urls-bitly and firestore-bigquery-export extensions with fixes to the database region parameters and adjustments to parameter mutability.

  • Bumped version numbers from 0.2.0 to 0.2.1
  • Updated region select options labels and values
  • Changed region parameter immutability from true to false

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
firestore-shorten-urls-bitly/extension.yaml Updated version, region labels, and made the region parameter mutable
firestore-shorten-urls-bitly/CHANGELOG.md Changelog updated to record the fixes and version bump
firestore-bigquery-export/extension.yaml Updated version, region labels, and made the region parameter mutable
firestore-bigquery-export/CHANGELOG.md Changelog updated to record the fixes and version bump
Comments suppressed due to low confidence (3)

firestore-shorten-urls-bitly/extension.yaml:239

  • Since the region parameter is now mutable, please ensure that unit tests cover scenarios where the region may be updated.
immutable: false

firestore-bigquery-export/extension.yaml:315

  • Since the region parameter is now mutable, please ensure that unit tests cover scenarios where the region may be updated.
immutable: false

firestore-bigquery-export/CHANGELOG.md:7

  • [nitpick] Consider using a colon instead of a hyphen for the changelog entry to maintain consistent formatting (e.g., 'feat: migrate to v2 functions and support non-default firestore instances').
feat - migrate to v2 functions and support non-default firestore instances

Copy link
Member

@CorieW CorieW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cabljac cabljac merged commit b4fcdc2 into master Apr 22, 2025
9 checks passed
cabljac added a commit that referenced this pull request Apr 22, 2025
Merge pull request #2384 from firebase/next
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants