Skip to content

chore: fix install script for Windows #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pleskac-figma wants to merge 2 commits into from
Closed

chore: fix install script for Windows #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec68c98
chore: fix install script for Windows
pleskac-figma Jun 30, 2025
f52d08c
chore: use the commit https://github.com/nodegit/nodegit/commit/c12c5…
pleskac-figma Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lifecycleScripts/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ module.exports = function install() {
}

return new Promise(function(resolve, reject) {
const gypPath = path.join(__dirname, "..", "node_modules", "node-gyp", "bin", "node-gyp.js");
var spawnedNodePreGyp = spawn(nodePreGyp, args, {
env: Object.assign({}, process.env, {
npm_config_node_gyp: path.join(__dirname, "..", "node_modules",
"node-gyp", "bin", "node-gyp.js")
})
env: {
...process.env,
npm_config_node_gyp: gypPath
},
shell: process.platform === "win32"
Comment on lines +29 to +35
Copy link
Author

@pleskac-figma pleskac-figma Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nodegit@c12c5a4

Perhaps we could also just pull in all 70 commits from nodegit/nodegit?

});

spawnedNodePreGyp.stdout.on("data", function(data) {
Expand Down Expand Up @@ -60,6 +62,6 @@ if (require.main === module) {
.catch(function(e) {
console.error("[nodegit] ERROR - Could not finish install");
console.error("[nodegit] ERROR - finished with error code: " + e);
process.exit(e);
process.exit(1);
});
}
Loading