Skip to content

Conversation

@dahlia
Copy link
Member

@dahlia dahlia commented Dec 26, 2025

Summary

  • Upgrade LogTape from 1.2.2 to 1.3.5
  • Upgrade Optique from 0.8.1 to 0.8.2
  • Upgrade ioredis from 5.6.1 to 5.8.2
  • Upgrade amqplib from 0.10.8 to 0.10.9
  • Upgrade OpenTelemetry SDK from 1.x to 2.x (breaking change)
  • Upgrade pkijs from 3.2.4 to 3.3.3
  • Upgrade asn1js from 3.0.5 to 3.0.7
  • Upgrade es-toolkit from 1.42.0 to 1.43.0 and unify to pnpm catalog

OpenTelemetry SDK 2.x migration

This PR includes breaking changes for OpenTelemetry SDK 2.x. For details, see the official migration guide:
https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/upgrade-to-2.x.md

Key changes in this PR:

  • span.parentSpanIdspan.parentSpanContext?.spanId
  • BasicTracerProvider.addSpanProcessor() → constructor options spanProcessors: [...]
  • instrumentationLibraryinstrumentationScope
  • Updated documentation examples in docs/manual/opentelemetry.md
  • Updated @opentelemetry/exporter-trace-otlp-proto and @opentelemetry/sdk-node to 0.208.0

Test plan

  • deno task test passed
  • pnpm run -r test passed
  • Pre-commit hooks (type checking) passed for all commits

dahlia and others added 8 commits December 26, 2025 13:14
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BREAKING CHANGES:
- BasicTracerProvider.addSpanProcessor() is removed;
  use constructor options instead
- ReadableSpan.parentSpanId is replaced with parentSpanContext
- ReadableSpan.instrumentationLibrary is renamed to instrumentationScope

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Upgraded es-toolkit from 1.42.0 to 1.43.0 and moved the dependency
from packages/fedify/deno.json to the root deno.json for centralized
management. The package.json now uses pnpm catalog reference.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@issues-auto-labeler issues-auto-labeler bot added breaking change Breaking change component/integration Web framework integration difficulty/intermediate Intermediate level labels Dec 26, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dahlia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive update of various project dependencies, addressing both minor and major version changes. The most significant aspect is the migration to OpenTelemetry SDK 2.x, which necessitated several code adjustments to align with its new API. These updates aim to enhance the project's stability, performance, and leverage the latest features and security improvements from the upgraded libraries.

Highlights

  • Dependency Upgrades: Multiple core dependencies have been upgraded to their latest versions, including LogTape (1.2.2 to 1.3.5), Optique (0.8.1 to 0.8.2), ioredis (5.6.1 to 5.8.2), amqplib (0.10.8 to 0.10.9), pkijs (3.2.4 to 3.3.3), asn1js (3.0.5 to 3.0.7), and es-toolkit (1.42.0 to 1.43.0).
  • OpenTelemetry SDK 2.x Migration: The OpenTelemetry SDK has been upgraded from version 1.x to 2.x, which is a breaking change. This involved updating API usage such as changing 'span.parentSpanId' to 'span.parentSpanContext?.spanId', replacing 'BasicTracerProvider.addSpanProcessor()' with constructor options 'spanProcessors: [...]', and renaming 'instrumentationLibrary' to 'instrumentationScope'. Related documentation examples and specific OpenTelemetry exporter/SDK packages have also been updated.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades several dependencies, most notably the OpenTelemetry SDK from version 1.x to 2.x. This is a significant update with breaking changes, and you've handled it very well. The code has been correctly adapted to the new OpenTelemetry API, including changes to TracerProvider initialization and accessing parent span information. I appreciate that you've also updated the documentation and tests to reflect these changes. The other dependency upgrades are straightforward and look good. Overall, this is a solid and well-executed pull request. I have no further comments.

@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
packages/fedify/src/otel/exporter.ts 86.15% <100.00%> (ø)
packages/fedify/src/testing/otel.ts 73.33% <100.00%> (+0.60%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sij411
Copy link
Contributor

sij411 commented Dec 26, 2025

Unless we have other packages to update, it looks clean.

@dahlia dahlia merged commit 96a0069 into fedify-dev:next Dec 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaking change component/integration Web framework integration difficulty/intermediate Intermediate level

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants