-
-
Notifications
You must be signed in to change notification settings - Fork 88
Upgrade dependencies: LogTape, Optique, OpenTelemetry SDK 2.x, and others #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BREAKING CHANGES: - BasicTracerProvider.addSpanProcessor() is removed; use constructor options instead - ReadableSpan.parentSpanId is replaced with parentSpanContext - ReadableSpan.instrumentationLibrary is renamed to instrumentationScope Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Upgraded es-toolkit from 1.42.0 to 1.43.0 and moved the dependency from packages/fedify/deno.json to the root deno.json for centralized management. The package.json now uses pnpm catalog reference. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @dahlia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update of various project dependencies, addressing both minor and major version changes. The most significant aspect is the migration to OpenTelemetry SDK 2.x, which necessitated several code adjustments to align with its new API. These updates aim to enhance the project's stability, performance, and leverage the latest features and security improvements from the upgraded libraries. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades several dependencies, most notably the OpenTelemetry SDK from version 1.x to 2.x. This is a significant update with breaking changes, and you've handled it very well. The code has been correctly adapted to the new OpenTelemetry API, including changes to TracerProvider initialization and accessing parent span information. I appreciate that you've also updated the documentation and tests to reflect these changes. The other dependency upgrades are straightforward and look good. Overall, this is a solid and well-executed pull request. I have no further comments.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
Unless we have other packages to update, it looks clean. |
Summary
OpenTelemetry SDK 2.x migration
This PR includes breaking changes for OpenTelemetry SDK 2.x. For details, see the official migration guide:
https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/upgrade-to-2.x.md
Key changes in this PR:
span.parentSpanId→span.parentSpanContext?.spanIdBasicTracerProvider.addSpanProcessor()→ constructor optionsspanProcessors: [...]instrumentationLibrary→instrumentationScopedocs/manual/opentelemetry.md@opentelemetry/exporter-trace-otlp-protoand@opentelemetry/sdk-nodeto 0.208.0Test plan
deno task testpassedpnpm run -r testpassed