Skip to content

Conversation

@easilok
Copy link
Contributor

@easilok easilok commented Jan 13, 2026

Motivation

With the persistent player feature requiring the usage of framesets, there are different pages endpoints for the ones that need to change its content based on the type of player the user has enabled. As consequence, in the initial works, different clip templates were created for each page endpoint with a lot of duplicated code and requiring changes on both templates on future work.

Approach

This PR leverages the clip templating properties to use an attribute to the render indicating if the page is on a frameset view or not. With that property, the engine renders different parts of the page, matching the expected view.

This approach leads to a big code duplication removal (specially on the HTML templates) and ensures future changes are contained and matched on both visualizations.

Test

  • Tested all pages in persistent player view and standard view
  • Tested with login that all pages can be navigated to

Observations

This is the first PR on this series of template duplication refactor. Next steps are:

  • Have a single navbar file that is rendered on all pages
  • Have a single footer file that is rendered on all pages
  • Improve analyzer visualization on content frames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant