Merge page and frameset pages into single template #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the persistent player feature requiring the usage of framesets, there are different pages endpoints for the ones that need to change its content based on the type of player the user has enabled. As consequence, in the initial works, different clip templates were created for each page endpoint with a lot of duplicated code and requiring changes on both templates on future work.
Approach
This PR leverages the clip templating properties to use an attribute to the render indicating if the page is on a frameset view or not. With that property, the engine renders different parts of the page, matching the expected view.
This approach leads to a big code duplication removal (specially on the HTML templates) and ensures future changes are contained and matched on both visualizations.
Test
Observations
This is the first PR on this series of template duplication refactor. Next steps are: