Skip to content

fix(macro): nullable parameters #538 #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kakserpom wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(macro): nullable parameters #538 #617

kakserpom wants to merge 3 commits into from
+247 −44

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Dec 18, 2025 •
edited
Loading

Fixes #538
Fixes #186
Fixes #305

@ptondereau
Copy link
Member

ptondereau commented Dec 18, 2025

bugfix doesn't exist in conventional commit.

@coveralls
Copy link

coveralls commented Dec 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20424967253

Details

  • 30 of 100 (30.0%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 35.831%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/describe/mod.rs 2 4 50.0%
src/describe/stub.rs 0 6 0.0%
src/constant.rs 0 9 0.0%
crates/macros/src/function.rs 11 34 32.35%
src/convert.rs 7 37 18.92%
Files with Coverage Reduction New Missed Lines %
src/constant.rs 3 0.0%
Totals Coverage Status
Change from base Build 20416026788: -0.2%
Covered Lines: 1693
Relevant Lines: 4725
💛 - Coveralls

@kakserpom kakserpom changed the title bugfix(macro): nullable parameters #538 fix(macro): nullable parameters #538 Dec 18, 2025
@kakserpom
Copy link
Contributor Author

kakserpom commented Dec 18, 2025

@ptondereau What a weird CI fail...

ptondereau
ptondereau previously approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kakserpom kakserpom force-pushed the 538_nullable_param branch 2 times, most recently from fdb4a91 to e0af8c1 Compare December 21, 2025 17:18
ptondereau
ptondereau previously approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptondereau ptondereau ptondereau left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@kakserpom @ptondereau @coveralls