Add v26 fixtures #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
ElpParserclass and its corresponding unit tests to update the handling of ELP file versions. The most important changes include modifying the version detection logic, updating metadata extraction methods, and revising the unit tests to reflect the new versioning scheme.Changes to version detection and metadata extraction:
src/ElpParser.php: Updated the version detection logic to correctly identify version 3 ELP files based on the presence of bothcontent.xmlandindex.html. Adjusted the metadata extraction methods to align with the new versioning scheme. [1] [2] [3]Updates to unit tests:
tests/Unit/ElpParserTest.php: Revised the unit tests to validate the parsing and metadata extraction for version 3 ELP files. Added new tests for additional version 3 ELP files and adjusted existing tests to ensure accurate version detection and metadata validation. [1] [2] [3] [4] [5]Additionally, minor changes were made to the
.gitattributesfile to include new entries for export-ignore:.gitattributes: Added entries for.gitattributes,.gitignore,.php-cs-fixer.dist.php, and.readthedocs.yamlto the export-ignore list.