Skip to content

Conversation

@erseco
Copy link
Collaborator

@erseco erseco commented Dec 10, 2024

This pull request adds new test cases to the tests/Unit/ElpParserTest.php file to ensure that the ELPParser can correctly parse different versions of ELP files. The most important changes include adding tests for parsing version v26 ELP files.

New test cases added:

  • Added a test case can parse a version v26 simple ELP file to verify the parsing of a simple ELP file created with version 2.6. This test checks for version detection, metadata fields, and extracted strings.
  • Added a test case can parse a version v26 more simple ELP file to verify the parsing of a more simplified ELP file created with version 2.6. This test also checks for version detection, metadata fields, and extracted strings.

I added some v26 fictures that @pabloamayab used on this exelearning-web PR https://github.com/exelearning/exelearning-web/pull/164

@erseco erseco requested a review from pabloamayab December 10, 2024 06:23
@erseco erseco self-assigned this Dec 10, 2024
@pabloamayab pabloamayab merged commit 36e8658 into main Dec 11, 2024
12 checks passed
@pabloamayab pabloamayab deleted the add-v26-fixtures branch December 11, 2024 11:23
erseco added a commit that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants