Skip to content

Conversation

@mmcky
Copy link
Member

@mmcky mmcky commented Oct 20, 2025

These are some minor changes for #146 -- will see if Teachbooks team want to merge them upstream to the Fork first, otherwise we can merge this once #146 is closed.

douden and others added 4 commits July 28, 2025 17:07
Added *.json, *.mo, and *.py files from the sphinx_proof directory to the package manifest for more comprehensive distribution. Removed global recursive inclusion of *.pot, *.po, and *.mo files.
Added and updated translations for mathematical proof terms in multiple languages across all JSON files. Also updated and added compiled .mo files for new and existing locales to support broader internationalization.
Introduces a new 'notation' directive and node to the Sphinx Proof extension, including registration in NODE_TYPES and PROOF_TYPES. Adds a Notation.json file with translations for 'Notation' in multiple languages and updates .mo files for localization support.
- Fixed Remark translations that incorrectly used 'Observation':
  - Spanish (es): Observación → Nota
  - Portuguese (pt): Observação → Nota
  - Italian (it): Osservazione → Nota
  - Greek (el): Παρατήρηση → Σημείωση
  - Romanian (ro): Observație → Remarcă

- Fixed Proposition translation in Polish:
  - Polish (pl): Twierdzenie → Propozycja
  (Twierdzenie means 'Theorem', not 'Proposition')

- Regenerated all affected locale .mo files
mmcky and others added 4 commits October 20, 2025 13:00
Resolved conflicts in translation files:
- Kept corrected translations for Remark (Spanish, Portuguese, Italian, Greek, Romanian)
- Kept corrected translation for Proposition (Polish)
- Regenerated all locale .mo files with correct translations

Conflicts resolved:
- sphinx_proof/translations/jsons/Remark.json
- sphinx_proof/translations/jsons/Proposition.json
- sphinx_proof/translations/locales/*/LC_MESSAGES/proof.mo (6 files)
Removed duplicate NotationDirective class that was causing issues.
Only one NotationDirective definition is needed.
Removed duplicate notation_node class in nodes.py.
Only one notation_node definition is needed.
@mmcky mmcky changed the title UPD: Updates to PR #146 MAINT: Minor changes to some translations and pre-commit fix (Updates to PR #146) Oct 20, 2025
@mmcky
Copy link
Member Author

mmcky commented Oct 20, 2025

Thanks again for #146 @douden -- here are the small fixes that you may be interested in on your end.

@mmcky mmcky merged commit 9512783 into main Oct 20, 2025
7 checks passed
@mmcky mmcky deleted the TeachBooks/main branch October 20, 2025 02:11
@douden
Copy link
Contributor

douden commented Oct 20, 2025

We will definitely sync our fork. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants