Skip to content

Conversation

@thomas-a-neil
Copy link
Contributor

No description provided.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

potential_sequence_of_concern,
return_bytes,
disable_cache,
headers,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Undefined Variable Causes Request Preparation Failure

The disable_cache variable is used in prepare_request and passed from _async_post and _post. However, it's not defined as a parameter in the signatures of prepare_request, _async_post, or _post, leading to a NameError.

Fix in Cursor Fix in Web

all_atom_pred_pos = all_atom_pred_pos[..., ca_pos, :]
all_atom_positions = all_atom_positions[..., ca_pos, :]
all_atom_mask = all_atom_mask[..., ca_pos : (ca_pos + 1)] # keep dim
all_atom_mask = all_atom_mask[..., ca_pos]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Mask Slicing Causes Tensor Shape Mismatch

The all_atom_mask slicing now removes a dimension, which was previously preserved. This creates a shape inconsistency with other tensors, potentially causing mismatches in downstream computations, especially within the compute_lddt function.

Fix in Cursor Fix in Web

@ebetica
Copy link
Contributor

ebetica commented Sep 17, 2025

lol ".post1" :D

@ebetica ebetica merged commit f4f9792 into main Sep 17, 2025
1 of 5 checks passed
@ebetica ebetica deleted the sync-3.2.2.post1 branch September 17, 2025 21:24
thomas-a-neil added a commit that referenced this pull request Sep 17, 2025
cmishra pushed a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants