chore(deps): replace pyth-sdk-solidity submodule with npm package #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I think the cleanest would be to move away from git submodules and to soldeer. This would allow a centralized management of dependencies across git and npmjs packages Replacing submodule with soldeer would look like below: install the repo as a dependncy like install dependencies for development with https://soldeer.xyz/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pyth-network/pyth-sdk-solidity
The above git repo is no longer available. Pyth network's crosschain monorepo now recommends using the npm package instead.
https://github.com/pyth-network/pyth-crosschain/tree/main/target_chains/ethereum/sdk/solidity#foundry