Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to bring
#SELECTABLEback to use by turning it into a visibility toggle instead, or an unlock system in other words.With this pull request, it modifies:
GetSteps()to filter out unselectable songs that have not been cleared -SongUtil.cppm_SelectionDisplay-Song.cppandSong.hSelectionDisplayinto a global enum -Song.h,NotesLoaderSM.cpp,NotesLoaderSMA.cpp,NotesLoaderSSC.cpp,NotesWriterSM.cpp,NotesWriterSSC.cpp,NotesWriterETT.cpp,SongCacheIndex.cpp,GameConstantsAndTypes.h, andGameConstantsAndTypes.cpp(yes it's that big)IsSelectable()andSetSelectable()-Song.cppWHEELDATA.SetAllSongs()to do the same thing asGetSteps()inSongUtil.cpp, but specifically for Rebirth -10 WheelDataManager.luaBONUS:
AddChildLua function, why not? -ActorFrame.cppThis PR isn't exactly done yet, as it needs a form of saving state at some point, with maybe fancier features.This PR is ready to be reviewed and pulled, this honestly is anticlimactic after literally posting yesterday.