Add is_higher_value_bid helper for bid forwarding threshold
#4792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use overflow-safe integer arithmetic via quotient/remainder splitting - Add MIN_BID_INCREASE_PERCENT config (minimum % increase to forward) - Add unit tests for threshold boundary cases
mkalinin
reviewed
Dec 16, 2025
14 tasks
jihoonsong
reviewed
Dec 19, 2025
| quotient = current_bid.value // 100 | ||
| remainder = current_bid.value % 100 | ||
| min_increase = quotient * MIN_BID_INCREASE_PERCENT | ||
| min_increase += (remainder * MIN_BID_INCREASE_PERCENT + 99) // 100 |
Member
There was a problem hiding this comment.
This is a ceiling so technically the threshold is ceiling of MIN_BID_INCREASE_PERCENT percent of current bid's value. I guess percentage gives us enough precision as value is in Gwei?
| - _[REJECT]_ `bid.execution_payment` is zero. | ||
| - _[IGNORE]_ this is the first signed bid seen with a valid signature from the | ||
| given builder for this slot. | ||
| - _[IGNORE]_ this bid is the highest value bid seen for the corresponding slot |
Member
There was a problem hiding this comment.
Is it better to describe something like "higher than other bids by at least MIN_BID_INCREASE_PERCENT"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DoS prevention, we should require that new bids be at least N% greater in value than the previous highest value bid before forwarding it to peers. This PR defines the percentage as 3% but we can change that to whatever we want. With 3%, an attacker would need to send ~701 valid signed bids to "spam" from 1 gwei to 1 ETH. This is the worst case scenario.
Also:
MIN_BID_INCREASE_PERCENTconfig (minimum % increase to forward)