Add I-Ching Package #208
Add I-Ching Package #208
Conversation
smeech
left a comment
smeech
left a comment
There was a problem hiding this comment.
A simple package of trigger:/replace: pairs. Many duplicate triggers, which will automatically generate a Search popup, which is fine. No script, shell or potentially malicious code.
I'll run the automated checks and let Copilot do its stuff.
Thank you!
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
This file needs to be removed to enable merging, please.
| description: Type I Ching Symbol with its corresponding binary code | ||
| version: 0.1.0 | ||
| author: Longman | ||
| tags: ["i-ching", "book of changes", "i ching"] No newline at end of file |
There was a problem hiding this comment.
Would you kindly add a homepage: key/value, even if the latter is just https://github.com/luklongman/hub/tree/main? If you have a better personal homepage, link to that.
There was a problem hiding this comment.
Pull request overview
This PR adds a new I-Ching package (version 0.1.0) that provides text expansion shortcuts for I Ching (Book of Changes) Unicode symbols, including hexagrams, trigrams, bigrams, and monograms.
- Adds 549 text expansion triggers for I Ching symbols with multiple information formats (symbol-only, Chinese name, English name, and reference links)
- Includes comprehensive documentation explaining the binary code-based trigger system
- Provides metadata and configuration for the package
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/i-ching/0.1.0/package.yml | Defines all text expansion matches for I Ching symbols with triggers following a binary code pattern |
| packages/i-ching/0.1.0/_manifest.yml | Package metadata including name, version, author, and tags |
| packages/i-ching/0.1.0/README.md | User documentation explaining installation and usage patterns |
| .vscode/settings.json | VSCode spell checker configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - trigger: :ic101110 | ||
| replace: ䷱ | ||
| - trigger: :icc101110 | ||
| replace: "鼎卦 THE CAULDRON ䷱" |
There was a problem hiding this comment.
The replacement value includes both Chinese and English text "鼎卦 THE CAULDRON ䷱", which is inconsistent with the pattern used for all other :icc triggers. The :icc format should only contain the Chinese name and symbol (like "鼎卦 ䷱"), while English names should only appear in :ice triggers.
| replace: "鼎卦 THE CAULDRON ䷱" | |
| replace: "鼎卦 ䷱" |
There was a problem hiding this comment.
I suspect this is intentional, as it's not the only instance. Feel free to ignore!
| replace: "THE CLINGING FIRE ䷝" | ||
| - trigger: :icl101101 | ||
| replace: "https://ctext.org/book-of-changes/li" | ||
| - trigger: :icc011100 |
There was a problem hiding this comment.
The trigger :icc011100 is used twice. Line 278 should use :ic011100 instead (without the extra 'c') to follow the pattern where :ic is for the symbol only, and :icc is for the Chinese name with symbol.
| - trigger: :icc011100 | |
| - trigger: :ic011100 |
There was a problem hiding this comment.
I suspect this is intentional, as it's not the only instance. Feel free to ignore!
2 participants
No description provided.