Skip to content

Conversation

@bjosv
Copy link
Collaborator

@bjosv bjosv commented May 27, 2025

  • Build common code using OTP25
  • Add debugger_support for OTP26 and OTP27
  • Remove debugger_support for OTP23 and OTP24
  • Update rebar3 version to 3.24.0
    Using a rebar3 version with OTP support range: 25-27
  • Update erlide_kernel version to 0.118.0

(Individual commits should be merged to keep needed steps for future changes.)

bjosv added 9 commits May 27, 2025 10:46
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
dbg_*.erl and int.erl copied from otp_src_26.2.5.12.tar.gz
located in otp_src_26.2.5.12/lib/debugger/src/

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
dbg_*.erl and int.erl copied from otp_src_27.3.3.tar.gz
located in otp_src_27.3.3/lib/debugger/src/

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Apply the same changes done in erlide_debugger_25 but
add comments to highlight the modifications.

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Use a rebar3 version with OTP support range: 25-27

File copied from:
https://github.com/erlang/rebar3/releases/download/3.24.0/rebar3

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Using
git ls-files | xargs sed -i 's|0\.117\.0|0.118.0|g'

and manual update of erlide_debugger_25.app.src

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@zuiderkwast
Copy link
Collaborator

How much of this is automated and which parts are not? What needs to be reviewed manually?

I read that OTP 28 has an "experimental API for a native debugger" in the release notes, https://www.erlang.org/downloads/28 so in the future we can reduce some of this code hopefully.

@bjosv
Copy link
Collaborator Author

bjosv commented Jun 2, 2025

How much of this is automated and which parts are not? What needs to be reviewed manually?

The PR is mainly a repetition of the needed steps we did in the previous lift.
Each commit has some descriptions where it comes from, or what search&replace command that was run.

Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's tested and it works, then I don't think it's necessary to review all of this very carefully. Feel free to merge it if you feel comfortable.

@bjosv bjosv merged commit ba61079 into erlang:master Jun 3, 2025
1 check passed
@bjosv bjosv deleted the update-supported-otp branch June 3, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants