Code clean-up #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, `Piper` depended on `DataMapping`, though this created a strange relationship between these classes (e.g. why do you need a `Piper` in the first place?). This commit cleans-up the relationship: - `Piper` is now independent: just used for processing transformation logic (`dict -> dict`) - `DataMapping` only goes in a single direction (KISS) - `DataMapping` takes transformation logic (in a `Piper` class) and input + output schema validation
Make more focused and tailored for eventual Rust migration
Can add back later if needed
`chidian_rs` is a bit ambiguous since this isn't the broader Rust package, rather it's the python-specific Rust helpers.
Focus on python features and Pydantic 2.0, add custom Rust if/when use cases come up (until then don't over-optimize)
Replace regex-based parsing
For clarity -- prioritize practicality before getting "cute" with it!
Replaces `DictGroup`
- Replace `>>` operator with `|` operator for partials DSL - Remove references to Rust core/engine in README (might add back later) - Solidify chidian's stance as pure Python framework (for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3
Simplified abstractions and focusing on pure Python for now!