Importing issue fixed #40
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This pull request updates the
missingpyrepository to be compatible with the current versions ofscikit-learnandnumpy. The following changes have been made:Compatibility Updates:
scikit-learnandnumpy.Code Refactoring:
_check_weightmethod asdef _check_weights(weights):to enhance clarity and consistency.Model Hyperparameters Update:
RandomForest.Details
_check_weightsRefactoring:The
_check_weightmethod has been refactored todef _check_weights(weights):for improved readability and maintainability. It is no longer present.The function now validates weights to ensure they are either 'uniform', 'distance', or a callable function. This modification enhances the robustness of the code and provides a clear interface for handling different weight options.Model Hyperparameters Update:
The model hyperparameters have been adjusted to fit the requirements of the current version of
RandomForest. This ensures that the imputation process aligns seamlessly with the latest changes in thescikit-learnlibrary.Testing
All existing tests have been updated and reruned to validate that the updated code functions correctly with the latest dependencies.
Related Issues
[Closes #13]