Fix target model initialisation #486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This update postpones surrogate model initialisation in BOLFI and BOLFIRE until
n_initial_evidencedata points are available and initialises the model based on all this data. Fixes #425In the current implementation, the model is initialised based on
batch_sizedata points. This is a problem whenbatch_sizeis small because the priors applied on the default kernel are also determined based on the initialisation data and become sensitive to the random seed. For example, see what happens in BOLFI tutorial notebook withseed=310522vsseed=1or BOLFIRE tutorial notebook withseed=100123vsseed=10.Please make sure
If your contribution adds, removes or somehow changes the functional behavior of the package, please check that
make lint,make docsandmake testand the proposed changes pass all unit tests (check step 6 of CONTRIBUTING.rst for details)
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: