fix(BubbleList): 滚动过程的滚动距离计算

[wumo1016]

修复 BubbleList 的滚动过程的最后滚动距离计算

在对话过程中，如果当前块的总高度变小，会导致下图这里进行误判，误以为是用户进行了向上的滚动，而实际是总高度变小，未处理 lastScrollTop.value 的边界

Summary by CodeRabbit

• Bug Fixes
  • Improved scroll handling to prevent issues when the scrollable area shrinks, ensuring smoother and more reliable scrolling behavior.

[coderabbitai]

Walkthrough

A safety check was added to the handleScroll function in the BubbleList component to ensure that the stored scroll position does not exceed the maximum possible value when the scroll container's height shrinks. This prevents invalid scroll positions during dynamic content changes.

Changes

File	Summary
packages/core/src/components/BubbleList/...	Added a check in handleScroll to cap lastScrollTop.value at the maximum valid value.

Poem

A scroll so smooth, a bubble's delight,
Now kept in bounds, no more a fright.
When heights shrink down, we hop with care,
Ensuring our scroll stays right where
It belongs—safe, snug, and bright!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/core/src/components/BubbleList/index.vue (1)

178-182: Good fix, but consider handling the edge case where content doesn't require scrolling.

The safety check correctly prevents invalid scroll positions when content height shrinks. However, consider the edge case where clientHeight > scrollHeight (content fits entirely without scrolling) - in this case, maxScrollTop would be negative.

Consider this improvement to handle the edge case:

-    // 处理 lastScrollTop.value 安全距离(scrollHeight 在滚动过程中变小)
-    const maxScrollTop = scrollHeight - clientHeight;
+    // 处理 lastScrollTop.value 安全距离(scrollHeight 在滚动过程中变小)
+    const maxScrollTop = Math.max(0, scrollHeight - clientHeight);
     if (lastScrollTop.value > maxScrollTop) {
       lastScrollTop.value = maxScrollTop;
     }

This ensures maxScrollTop is never negative when content doesn't require scrolling.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b7772e and 1d352cf.

📒 Files selected for processing (1)

• packages/core/src/components/BubbleList/index.vue (1 hunks)