Skip to content

Conversation

@pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 19, 2025

Notes:

@pixlwave pixlwave requested a review from a team as a code owner December 19, 2025 13:02
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 19, 2025
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 19, 2025 13:02
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 20505d2

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 52.38095% with 250 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.41%. Comparing base (6153480) to head (20505d2).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...QRCodeLoginScreen/QRCodeLoginScreenViewModel.swift 32.00% 102 Missing ⚠️
...tensions/AVMetadataMachineReadableCodeObject.swift 49.47% 48 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 30 Missing ⚠️
...lowCoordinators/LinkNewDeviceFlowCoordinator.swift 0.00% 19 Missing ⚠️
...Services/Authentication/LinkNewDeviceService.swift 26.66% 11 Missing ⚠️
...owCoordinators/AuthenticationFlowCoordinator.swift 0.00% 8 Missing ⚠️
...CodeLoginScreen/QRCodeLoginScreenCoordinator.swift 0.00% 8 Missing ⚠️
...ens/QRCodeLoginScreen/View/QRCodeScannerView.swift 0.00% 8 Missing ⚠️
...ns/QRCodeLoginScreen/QRCodeLoginScreenModels.swift 89.23% 7 Missing ⚠️
...ens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift 95.53% 5 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4891      +/-   ##
===========================================
- Coverage    79.49%   79.41%   -0.09%     
===========================================
  Files          892      892              
  Lines        65040    65319     +279     
===========================================
+ Hits         51705    51870     +165     
- Misses       13335    13449     +114     
Flag Coverage Δ
unittests 71.22% <52.38%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/qr-code-linking branch from 84af1be to 35b6dd3 Compare December 19, 2025 17:03
@pixlwave pixlwave force-pushed the doug/qr-code-linking branch from 35b6dd3 to 20505d2 Compare December 19, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-wip for anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants