-
Notifications
You must be signed in to change notification settings - Fork 222
Add support for linking new devices in the QRCodeLoginScreen. #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger Swift against 20505d2 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4891 +/- ##
===========================================
- Coverage 79.49% 79.41% -0.09%
===========================================
Files 892 892
Lines 65040 65319 +279
===========================================
+ Hits 51705 51870 +165
- Misses 13335 13449 +114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
84af1be to
35b6dd3
Compare
… to link a new device. This will be merged together with the existing QRCodeLoginScreen.
35b6dd3 to
20505d2
Compare
Notes:
Based on https://github.com/hughns/element-x-ios/tree/msc4108-v2025 (although some of this is already in the app now from previous PRs).
There's still SDK updates required for this such as feat(sdk,ffi): add
CheckCodeSender::validate()matrix-org/matrix-rust-sdk#5957 (but everything is behind a feature flag so it is safe to merge).I've only tested the "Link Mobile Device" flow. I believe linking against EW needs a specific build.
Still needs some unit tests, but preview tests are there.