Skip to content

Conversation

@jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Dec 18, 2025

Content

  • Add TransactionDefinition class as a way to describe the analytics transactions from the matrix metrics spec (pun intended). Add them to the AnalyticsTransactions object.
  • Base AnalyticsLongRunningTransactions on these definitions, add a description optional field to sentry transactions.
  • Add AnalyticsSendMessageWatcher to track the last missing UX flow: sending a message and receiving it back from /sync.

Motivation and context

Part of the work for #5890.

Tests

Perform some of these actions, see they are uploaded to Sentry with the proper values.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 16

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

…e right fields (name, operation, description)
…vent to be sent and for us to get a call back for that from sync
@jmartinesp jmartinesp added the PR-Misc For other changes label Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/j2NKu7

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 65.83333% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.39%. Comparing base (8948c2e) to head (ecfc858).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
.../libraries/matrix/impl/room/SendQueueUpdatesExt.kt 0.00% 12 Missing ⚠️
...droid/libraries/matrix/api/room/SendQueueUpdate.kt 28.57% 5 Missing ⚠️
...mpl/watchers/DefaultAnalyticsSendMessageWatcher.kt 82.75% 1 Missing and 4 partials ⚠️
...droid/libraries/matrix/impl/room/JoinedRustRoom.kt 0.00% 3 Missing ⚠️
...services/analytics/impl/DefaultAnalyticsService.kt 0.00% 3 Missing ⚠️
...s/noop/watchers/NoopAnalyticsSendMessageWatcher.kt 0.00% 3 Missing ⚠️
...s/analytics/api/AnalyticsLongRunningTransaction.kt 75.00% 2 Missing ⚠️
...ticsproviders/sentry/SentryAnalyticsTransaction.kt 33.33% 1 Missing and 1 partial ⚠️
...atures/messages/impl/timeline/TimelinePresenter.kt 0.00% 1 Missing ⚠️
...es/test/pinned/FakePinnedEventsTimelineProvider.kt 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5937      +/-   ##
===========================================
+ Coverage    81.36%   81.39%   +0.02%     
===========================================
  Files         2489     2496       +7     
  Lines        66423    66517      +94     
  Branches      8449     8461      +12     
===========================================
+ Hits         54046    54141      +95     
+ Misses        9268     9264       -4     
- Partials      3109     3112       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp marked this pull request as ready for review December 19, 2025 12:18
@jmartinesp jmartinesp requested a review from a team as a code owner December 19, 2025 12:18
@jmartinesp jmartinesp requested review from ganfra and removed request for a team December 19, 2025 12:18
@manuroe
Copy link
Member

manuroe commented Dec 23, 2025

image

Do you think it will be possible to include more spans from the SDK to the Catch-up metric? Having /sync request span would be a useful information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants