-
Notifications
You must be signed in to change notification settings - Fork 195
Fixing applies_to tags #4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fixing applies_to tags #4465
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7f0b1a1
Fixing applies_to tags
yetanothertw 8ff3be9
Merge branch 'main' into troubleshooting-tags-fix
yetanothertw dd24916
Updating tab headers for alignment
yetanothertw ba19ed3
Working in a few more updates for the index allocation page
yetanothertw 40453f4
Tidying up tags for the Circuit breaker errors
yetanothertw 4a93ed0
Fixing the Troubleshoot data corruption tags
yetanothertw 9e3998f
Update topics to remove unnecessary tabs
yetanothertw aaaf76b
reverting the autoops snippet change
yetanothertw 23aadaa
Merge branch 'main' into troubleshooting-tags-fix
yetanothertw 72f0756
Adding correct tags to Troubleshoot data corruption
yetanothertw 05bd5a6
Update the Preferred data tier page as per review feedback
yetanothertw 18a1f70
Adding note to Troubleshooting data corruption
yetanothertw 2748d84
Add applies_to tags to the note admonition
yetanothertw fb76339
changed some wording based on other examples
yetanothertw d7ad0fc
Making more edits as per review suggestions
yetanothertw 5cd80d3
Fix broken link
yetanothertw f3047d5
Merge branch 'main' into troubleshooting-tags-fix
yetanothertw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,6 @@ | ||
| --- | ||
| applies_to: | ||
| stack: | ||
| deployment: | ||
| eck: | ||
| ess: | ||
| ece: | ||
| self: | ||
| navigation_title: "Error: All shards failed" | ||
| --- | ||
|
|
||
|
|
||
yetanothertw marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetanothertw marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this tutorial is no longer really doing anything / it's unclear what the "action" is. the order needs to be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed this in a new commit, let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want to be in a situation where we only have ECH and self-managed instructions, when the page is supposed to apply to ECH/ECE/ECK/self-managed (self-managed in docs always meaning a fully, manually self-managed cluster). this organization is close, but ECE follows the ECH path and ECK has some extra requirements not documented at this link.
IMO the easiest way to fix this is to break it up into two sections:
step 1: determine target tier
step 2: resize (with pathways for each deployment type)
the info customers need here is similar to this note:
https://github.com/elastic/docs-content/pull/4475/files#diff-2ffc185dff3a45f8a151a9cc15e01e15f80e04641d514bda1a53996490a46e63R16
I also provided some info here: #4465 (comment)
if you prefer, you can take the changes to this file out of this PR and we can handle it separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this makes more sense. Please let me know if this looks better now: https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/4465/troubleshoot/elasticsearch/add-tier