-
Notifications
You must be signed in to change notification settings - Fork 195
[Do not merge] Convert tabs that can be applies-switch #4429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Do not merge] Convert tabs that can be applies-switch #4429
Conversation
Vale Linting ResultsSummary: 17 suggestions found 💡 Suggestions (17)
|
|
Edit: found ittttt |
…-leborgne/docs-content into convert-tabs-into-applies-switch
|
@florent-leborgne , what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️ |
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of this looks good, but please skip the elasticsearch troubleshooting content. I'll need to fix it with the page-level issues
|
as a side note, there's only maybe a handful of things in here with a range ... this could be split and most of it could be merged ASAP |
…abs-into-applies-switch
leemthompo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 dev docs files lgtm
mdbirnstiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the most part, let me know if you want me to handle the comment I made.
solutions/observability/synthetics/create-monitors-with-projects.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingest docs LGTM, left some observations.
...ckstart-unified-kubernetes-observability-with-elastic-distributions-of-opentelemetry-edot.md
Show resolved
Hide resolved
Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>
Summary
This PR converts tabs that should now be applies-switch thanks to the recent and upcoming updates to the metadata system.
This PR should only be merged after elastic/docs-builder#2322 is merged.
CI should fail until then.
Contributes to: #4361
Generative AI disclosure