-
Notifications
You must be signed in to change notification settings - Fork 195
[Do not merge] Convert tabs that can be applies-switch #4429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Do not merge] Convert tabs that can be applies-switch #4429
Conversation
Vale Linting ResultsSummary: 2 warnings, 23 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
💡 Suggestions (23)
| File | Line | Rule | Message |
|---|---|---|---|
| deploy-manage/users-roles/cluster-or-deployment-auth/saml.md | 425 | Elastic.Acronyms | 'PEM' has no definition. |
| deploy-manage/users-roles/cluster-or-deployment-auth/saml.md | 540 | Elastic.Acronyms | 'SAML' has no definition. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 21 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.FutureTense | 'will need' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 81 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 82 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 27 | Elastic.FutureTense | 'will increase' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 139 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/repeated-snapshot-failures.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 231 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 20 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 24 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/troubleshoot-logs.md | 49 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI. |
|
Edit: found ittttt |
…-leborgne/docs-content into convert-tabs-into-applies-switch
|
@florent-leborgne , what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️ |
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of this looks good, but please skip the elasticsearch troubleshooting content. I'll need to fix it with the page-level issues
|
as a side note, there's only maybe a handful of things in here with a range ... this could be split and most of it could be merged ASAP |
…abs-into-applies-switch
leemthompo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 dev docs files lgtm
mdbirnstiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the most part, let me know if you want me to handle the comment I made.
|
|
||
| :::{tab-item} Elastic Stack | ||
| :sync: stack | ||
| :::{applies-item} stack: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the content in serverless and stack is identical here, not sure if that's out of the scope of this PR, if so, I can make the update in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the applies-switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingest docs LGTM, left some observations.
...ckstart-unified-kubernetes-observability-with-elastic-distributions-of-opentelemetry-edot.md
Show resolved
Hide resolved
Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>
Summary
This PR converts tabs that should now be applies-switch thanks to the recent and upcoming updates to the metadata system.
This PR should only be merged after elastic/docs-builder#2322 is merged.
CI should fail until then.
Contributes to: #4361
Generative AI disclosure