Skip to content

Conversation

@florent-leborgne
Copy link
Contributor

Summary

This PR converts tabs that should now be applies-switch thanks to the recent and upcoming updates to the metadata system.

This PR should only be merged after elastic/docs-builder#2322 is merged.

CI should fail until then.

Contributes to: #4361

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Vale Linting Results

Summary: 17 suggestions found

💡 Suggestions (17)
File Line Rule Message
deploy-manage/users-roles/cluster-or-deployment-auth/saml.md 425 Elastic.Acronyms 'PEM' has no definition.
deploy-manage/users-roles/cluster-or-deployment-auth/saml.md 540 Elastic.Acronyms 'SAML' has no definition.
troubleshoot/elasticsearch/increase-capacity-data-node.md 21 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/increase-capacity-data-node.md 57 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/increase-capacity-data-node.md 57 Elastic.FutureTense 'will need' might be in future tense. Write in the present tense to describe the state of the product as it is now.
troubleshoot/elasticsearch/increase-cluster-shard-limit.md 29 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/increase-cluster-shard-limit.md 81 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/increase-shard-limit.md 29 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/increase-shard-limit.md 82 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/increase-tier-capacity.md 27 Elastic.FutureTense 'will increase' might be in future tense. Write in the present tense to describe the state of the product as it is now.
troubleshoot/elasticsearch/increase-tier-capacity.md 139 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/repeated-snapshot-failures.md 27 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/restore-from-snapshot.md 27 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/elasticsearch/restore-from-snapshot.md 231 Elastic.Wordiness Consider using 'to' instead of 'In order to'.
troubleshoot/observability/apm/apm-server-response-codes.md 20 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI.
troubleshoot/observability/apm/apm-server-response-codes.md 24 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI.
troubleshoot/observability/troubleshoot-logs.md 49 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI.

@florent-leborgne
Copy link
Contributor Author

florent-leborgne commented Dec 19, 2025

I broke something in there which isn't obvious to find, 🕵️

Edit: found ittttt

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🔍 Preview links for changed docs

More links …

@benironside
Copy link
Contributor

@florent-leborgne , what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of this looks good, but please skip the elasticsearch troubleshooting content. I'll need to fix it with the page-level issues

@shainaraskas
Copy link
Collaborator

as a side note, there's only maybe a handful of things in here with a range ... this could be split and most of it could be merged ASAP

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 dev docs files lgtm

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part, let me know if you want me to handle the comment I made.

Copy link
Contributor

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingest docs LGTM, left some observations.

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants