Skip to content

Remove redundant key creation in dict #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepbrook wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove redundant key creation in dict #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pusherclient/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
from collections import defaultdict

class Channel(object):
def __init__(self, channel_name, connection):
self.name = channel_name

self.connection = connection

self.event_callbacks = {}
self.event_callbacks = defaultdict(list)

def bind(self, event_name, callback):
"""Bind an event to a callback
Expand All @@ -14,9 +16,6 @@ def bind(self, event_name, callback):

:param callback: The callback to notify of this event.
"""
if event_name not in self.event_callbacks.keys():
self.event_callbacks[event_name] = []

self.event_callbacks[event_name].append(callback)

def trigger(self, event_name, data):
Expand Down