Skip to content

Conversation

@pwnage101
Copy link
Member

ENT-11240

This enables support for the following make target:

make dev.migrate-repo-git-to-edx.license-manager
make dev.migrate-repo-git-to-edx.enterprise-access
make dev.migrate-repo-git-to-edx.enterprise-subsidy
make dev.migrate-repo-git-to-edx.enterprise-catalog
etc.

Copilot AI review requested due to automatic review settings December 9, 2025 07:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for migrating individual enterprise repository clones from the openedx to edx GitHub organization, in addition to the existing bulk migration functionality. The changes enable developers to run repository-specific migration commands like make dev.migrate-repo-git-to-edx.license-manager.

Key changes:

  • Added optional single-repository argument support to the migration shell script
  • Renamed and updated Makefile targets to support both bulk and individual repo migrations
  • Added pattern rules to enable service-specific shortcut syntax

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
migrate-repo-git-to-edx.sh Added conditional logic to accept a single repository name as an argument and limit execution to that repository only
Makefile Renamed migrate-enterprise-repos target to migrate-repo-git-to-edx, added dev.migrate-repo-git-to-edx.% pattern target, and created shortcut pattern rule using ALL_SERVICES_LIST
Comments suppressed due to low confidence (1)

migrate-repo-git-to-edx.sh:31

  • The script accepts an argument but doesn't validate if the provided repository name is valid. If an invalid repository name is passed (e.g., a typo), the script will silently skip it with "Skipping $repo (not found)" without indicating that the repository name itself might be incorrect. Consider adding validation to check if the provided repository is in the list of known repos, or at least provide a more informative message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just make sure to link this PR in the ticket itself as well

@pwnage101 pwnage101 merged commit 8d51f47 into master Dec 9, 2025
24 of 25 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-11240-2 branch December 9, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants