-
Notifications
You must be signed in to change notification settings - Fork 9
feat: use shared behavior class for updating email and username #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@eduNEXT/heimdall this PR is still a work in progress, but we have not been able to get a single successful Tutor integration test run. Do you know if there is something wrong with the pipeline? Thanks in advance! |
|
@eduNEXT/heimdall: I opened the PR so we can start the review process although I still have to add some integration tests for the replace-email endpoint. |
|
@mariajgrimaldi, the integration test fix has been applied. Could you please rebase this PR with master? |
Refactor the current username update flow to use a shared behavior class and base updater view and serializer. This enables supporting email updates separately via a different endpoint.
5801a6c to
f9569e1
Compare
|
@magajh, thanks! I'll be implementing the integration tests for the replace-email endpoint |
Description
Refactor the current username update flow to use a shared behavior class and base updater view and serializer. This enables supporting email updates separately via a different endpoint.
Testing instructions
{{domain}}/eox-core/api/v1/user/with the following payload:I'll implement integration tests once the pipeline is fixed cause I tried running it locally but failed doing so.
Additional information
A client requested the ability to update a user's email address immediately after it is changed in their single sign-on (SSO) identity provider. This is required to maintain GDPR compliance, as communications must always be delivered to the correct and current email recipient. Currently, although the email can be updated via SSO, the change is not applied in the platform until the user logs in. This creates a risk where emails are sent to an outdated address if the user does not log in immediately, potentially resulting in non-compliance with GDPR data management standards.
Checklist for Merge